Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Unified Diff: chrome/browser/chromeos/ui/accessibility_focus_ring_controller.cc

Issue 1147323003: Made the CompositorAnimationObserver class usable (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: nit Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/ui/accessibility_focus_ring_controller.cc
diff --git a/chrome/browser/chromeos/ui/accessibility_focus_ring_controller.cc b/chrome/browser/chromeos/ui/accessibility_focus_ring_controller.cc
index 9b9aa4ea71372a5da88cc05789a6d2dd32c489f9..073772fe4fadb233672333da422352116cc02b29 100644
--- a/chrome/browser/chromeos/ui/accessibility_focus_ring_controller.cc
+++ b/chrome/browser/chromeos/ui/accessibility_focus_ring_controller.cc
@@ -43,7 +43,7 @@ AccessibilityFocusRingController*
}
AccessibilityFocusRingController::AccessibilityFocusRingController()
- : compositor_(NULL) {
+ : compositor_(nullptr) {
}
AccessibilityFocusRingController::~AccessibilityFocusRingController() {
@@ -80,7 +80,7 @@ void AccessibilityFocusRingController::Update() {
layers_[0]->Set(rings_[0]);
if (compositor_ && compositor_->HasAnimationObserver(this)) {
compositor_->RemoveAnimationObserver(this);
- compositor_ = NULL;
+ compositor_ = nullptr;
}
continue;
}
@@ -309,7 +309,7 @@ void AccessibilityFocusRingController::OnAnimationStep(
if (delta >= transition_time) {
layers_[0]->Set(rings_[0]);
compositor_->RemoveAnimationObserver(this);
- compositor_ = NULL;
+ compositor_ = nullptr;
return;
}
@@ -322,4 +322,13 @@ void AccessibilityFocusRingController::OnAnimationStep(
previous_rings_[0], rings_[0], fraction));
}
+void AccessibilityFocusRingController::OnCompositingShuttingDown(
+ ui::Compositor* compositor) {
+ DCHECK_EQ(compositor_, compositor);
+ if (compositor_) {
danakj 2015/06/02 18:24:15 this cant be null can it?
+ compositor_->RemoveAnimationObserver(this);
+ }
+ compositor_ = nullptr;
+}
+
} // namespace chromeos

Powered by Google App Engine
This is Rietveld 408576698