runtime/vm/raw_object_snapshot.cc - Issue 1147303002: Support untagged object pool entries.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/raw_object_snapshot.cc

Issue 1147303002: Support untagged object pool entries. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: rebased Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/raw_object_snapshot.cc

diff --git a/runtime/vm/raw_object_snapshot.cc b/runtime/vm/raw_object_snapshot.cc

index 838145c485dbc1b8869a827f8aab7359da9f3881..e24cb36b0aa0d59404dc5d9058feaae6d78ae682 100644

--- a/runtime/vm/raw_object_snapshot.cc

+++ b/runtime/vm/raw_object_snapshot.cc

@@ -1262,6 +1262,22 @@ void RawCode::WriteTo(SnapshotWriter* writer,

}

+RawObjectPool* ObjectPool::ReadFrom(SnapshotReader* reader,

+ intptr_t object_id,

+ intptr_t tags,

+ Snapshot::Kind kind) {

+ UNREACHABLE();

+ return ObjectPool::null();

+void RawObjectPool::WriteTo(SnapshotWriter* writer,

+ intptr_t object_id,

+ Snapshot::Kind kind) {

+ UNREACHABLE();

RawInstructions* Instructions::ReadFrom(SnapshotReader* reader,

intptr_t object_id,

intptr_t tags,