Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1147293002: Stop dispatching mouse move events for wheel scrolling in X11. (Closed)

Created:
5 years, 7 months ago by tdresser
Modified:
5 years, 7 months ago
Reviewers:
sadrul
CC:
chromium-reviews, jdduke+watch_chromium.org, tdresser+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Stop dispatching mouse move events for wheel scrolling in X11. This only effects some mice, which send XI_Motion events for wheel scrolling. These extra mouse move events hurt performance. BUG=490220 Committed: https://crrev.com/5a9a71f25e745357a0512acafa0a9b5346a536a9 Cr-Commit-Position: refs/heads/master@{#331566}

Patch Set 1 #

Patch Set 2 : HasEventData checks array bounds. #

Patch Set 3 : Switch to CHECK. #

Total comments: 4

Patch Set 4 : Address sadrul's comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -11 lines) Patch
M ui/events/devices/x11/device_data_manager_x11.h View 1 2 3 3 chunks +5 lines, -4 lines 0 comments Download
M ui/events/devices/x11/device_data_manager_x11.cc View 1 2 3 3 chunks +14 lines, -5 lines 0 comments Download
M ui/events/test/events_test_utils_x11.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/events/test/events_test_utils_x11.cc View 1 chunk +11 lines, -2 lines 0 comments Download
M ui/events/x/events_x.cc View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M ui/events/x/events_x_unittest.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
tdresser
PTAL!
5 years, 7 months ago (2015-05-21 17:56:41 UTC) #2
tdresser
On 2015/05/21 17:56:41, tdresser wrote: > PTAL! Ping.
5 years, 7 months ago (2015-05-26 14:10:09 UTC) #3
sadrul
lgtm https://codereview.chromium.org/1147293002/diff/40001/ui/events/devices/x11/device_data_manager_x11.cc File ui/events/devices/x11/device_data_manager_x11.cc (right): https://codereview.chromium.org/1147293002/diff/40001/ui/events/devices/x11/device_data_manager_x11.cc#newcode422 ui/events/devices/x11/device_data_manager_x11.cc:422: CHECK(xiev->sourceid < kMaxDeviceNum); We don't really have control ...
5 years, 7 months ago (2015-05-26 17:52:51 UTC) #4
tdresser
https://codereview.chromium.org/1147293002/diff/40001/ui/events/devices/x11/device_data_manager_x11.cc File ui/events/devices/x11/device_data_manager_x11.cc (right): https://codereview.chromium.org/1147293002/diff/40001/ui/events/devices/x11/device_data_manager_x11.cc#newcode422 ui/events/devices/x11/device_data_manager_x11.cc:422: CHECK(xiev->sourceid < kMaxDeviceNum); On 2015/05/26 17:52:50, sadrul wrote: > ...
5 years, 7 months ago (2015-05-27 12:49:39 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147293002/60001
5 years, 7 months ago (2015-05-27 12:49:58 UTC) #8
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-05-27 13:27:17 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-27 13:28:04 UTC) #10
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/5a9a71f25e745357a0512acafa0a9b5346a536a9
Cr-Commit-Position: refs/heads/master@{#331566}

Powered by Google App Engine
This is Rietveld 408576698