Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2692)

Unified Diff: Source/web/WebFrameWidgetImpl.cpp

Issue 1147283002: Add ScrollDirectionPhysical enum in Scroll types. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixed a conflict on EventHandler Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/scroll/Scrollbar.cpp ('k') | Source/web/WebPluginContainerImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/WebFrameWidgetImpl.cpp
diff --git a/Source/web/WebFrameWidgetImpl.cpp b/Source/web/WebFrameWidgetImpl.cpp
index 90ea7baa0f68b43d85054fb64c270c58aacaa75b..efb09d35431cf0d467b456bacf930c1214bf2ffb 100644
--- a/Source/web/WebFrameWidgetImpl.cpp
+++ b/Source/web/WebFrameWidgetImpl.cpp
@@ -886,35 +886,35 @@ bool WebFrameWidgetImpl::mapKeyCodeForScroll(
{
switch (keyCode) {
case VKEY_LEFT:
- *scrollDirection = ScrollLeft;
+ *scrollDirection = ScrollLeftIgnoringWritingMode;
*scrollGranularity = ScrollByLine;
break;
case VKEY_RIGHT:
- *scrollDirection = ScrollRight;
+ *scrollDirection = ScrollRightIgnoringWritingMode;
*scrollGranularity = ScrollByLine;
break;
case VKEY_UP:
- *scrollDirection = ScrollUp;
+ *scrollDirection = ScrollUpIgnoringWritingMode;
*scrollGranularity = ScrollByLine;
break;
case VKEY_DOWN:
- *scrollDirection = ScrollDown;
+ *scrollDirection = ScrollDownIgnoringWritingMode;
*scrollGranularity = ScrollByLine;
break;
case VKEY_HOME:
- *scrollDirection = ScrollUp;
+ *scrollDirection = ScrollUpIgnoringWritingMode;
*scrollGranularity = ScrollByDocument;
break;
case VKEY_END:
- *scrollDirection = ScrollDown;
+ *scrollDirection = ScrollDownIgnoringWritingMode;
*scrollGranularity = ScrollByDocument;
break;
case VKEY_PRIOR: // page up
- *scrollDirection = ScrollUp;
+ *scrollDirection = ScrollUpIgnoringWritingMode;
*scrollGranularity = ScrollByPage;
break;
case VKEY_NEXT: // page down
- *scrollDirection = ScrollDown;
+ *scrollDirection = ScrollDownIgnoringWritingMode;
*scrollGranularity = ScrollByPage;
break;
default:
« no previous file with comments | « Source/platform/scroll/Scrollbar.cpp ('k') | Source/web/WebPluginContainerImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698