Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(562)

Unified Diff: Source/core/editing/EditorCommand.cpp

Issue 1147283002: Add ScrollDirectionPhysical enum in Scroll types. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixed a conflict on EventHandler Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/frame/FrameView.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/editing/EditorCommand.cpp
diff --git a/Source/core/editing/EditorCommand.cpp b/Source/core/editing/EditorCommand.cpp
index c2ddb806a47e74a84b24686260100019d34f86ef..50c269e292b058d13724991b98d80e32971454f9 100644
--- a/Source/core/editing/EditorCommand.cpp
+++ b/Source/core/editing/EditorCommand.cpp
@@ -999,12 +999,12 @@ static bool executeScrollPageForward(LocalFrame& frame, Event*, EditorCommandSou
static bool executeScrollLineUp(LocalFrame& frame, Event*, EditorCommandSource, const String&)
{
- return frame.eventHandler().bubblingScroll(ScrollUp, ScrollByLine);
+ return frame.eventHandler().bubblingScroll(ScrollUpIgnoringWritingMode, ScrollByLine);
}
static bool executeScrollLineDown(LocalFrame& frame, Event*, EditorCommandSource, const String&)
{
- return frame.eventHandler().bubblingScroll(ScrollDown, ScrollByLine);
+ return frame.eventHandler().bubblingScroll(ScrollDownIgnoringWritingMode, ScrollByLine);
}
static bool executeScrollToBeginningOfDocument(LocalFrame& frame, Event*, EditorCommandSource, const String&)
@@ -1699,10 +1699,10 @@ bool Editor::executeCommand(const String& commandName, const String& value)
{
// moveToBeginningOfDocument and moveToEndfDocument are only handled by WebKit for editable nodes.
if (!canEdit() && commandName == "moveToBeginningOfDocument")
- return frame().eventHandler().bubblingScroll(ScrollUp, ScrollByDocument);
+ return frame().eventHandler().bubblingScroll(ScrollUpIgnoringWritingMode, ScrollByDocument);
if (!canEdit() && commandName == "moveToEndOfDocument")
- return frame().eventHandler().bubblingScroll(ScrollDown, ScrollByDocument);
+ return frame().eventHandler().bubblingScroll(ScrollDownIgnoringWritingMode, ScrollByDocument);
if (commandName == "showGuessPanel") {
spellChecker().showSpellingGuessPanel();
« no previous file with comments | « no previous file | Source/core/frame/FrameView.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698