Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1071)

Unified Diff: Source/core/frame/FrameView.cpp

Issue 1147283002: Add ScrollDirectionPhysical enum in Scroll types. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/frame/FrameView.cpp
diff --git a/Source/core/frame/FrameView.cpp b/Source/core/frame/FrameView.cpp
index 1432240325fd570e797f6aa3ef3f0ce29cdc30b2..ada0d2034ca605c98509630843ef054fd306189c 100644
--- a/Source/core/frame/FrameView.cpp
+++ b/Source/core/frame/FrameView.cpp
@@ -3263,12 +3263,9 @@ void FrameView::setScrollOffset(const DoublePoint& offset)
scrollTo(adjustScrollPositionWithinRange(offset));
}
-bool FrameView::scroll(ScrollDirection direction, ScrollGranularity granularity, float delta)
+bool FrameView::scroll(ScrollDirectionPhysical direction, ScrollGranularity granularity, float delta)
bokan 2015/05/21 18:54:43 Just remove FrameView::scroll and let callers use
{
- ScrollDirection physicalDirection =
- toPhysicalDirection(direction, isVerticalDocument(), isFlippedDocument());
-
- return ScrollableArea::scroll(physicalDirection, granularity, delta);
+ return ScrollableArea::scroll(direction, granularity, delta);
}
void FrameView::windowResizerRectChanged()

Powered by Google App Engine
This is Rietveld 408576698