Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Unified Diff: Source/core/dom/Element.cpp

Issue 1147283002: Add ScrollDirectionPhysical enum in Scroll types. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/frame/FrameView.h » ('j') | Source/core/frame/FrameView.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/dom/Element.cpp
diff --git a/Source/core/dom/Element.cpp b/Source/core/dom/Element.cpp
index e707d9a03c44ac1db92742f0f7abda0bbeb1c381..661b449fc05cc6d06e8f2a52960fdff708228d6e 100644
--- a/Source/core/dom/Element.cpp
+++ b/Source/core/dom/Element.cpp
@@ -526,12 +526,12 @@ void Element::applyScroll(ScrollState& scrollState)
LayoutBox* curBox = layoutObject()->enclosingBox();
// FIXME: Native scrollers should only consume the scroll they
// apply. See crbug.com/457765.
- if (deltaX && curBox->scroll(ScrollLeft, ScrollByPrecisePixel, deltaX)) {
+ if (deltaX && curBox->scroll(ScrollPhysicalLeft, ScrollByPrecisePixel, deltaX)) {
scrollState.consumeDeltaNative(scrollState.deltaX(), 0);
scrolled = true;
}
- if (deltaY && curBox->scroll(ScrollUp, ScrollByPrecisePixel, deltaY)) {
+ if (deltaY && curBox->scroll(ScrollPhysicalUp, ScrollByPrecisePixel, deltaY)) {
scrollState.consumeDeltaNative(0, scrollState.deltaY());
scrolled = true;
}
« no previous file with comments | « no previous file | Source/core/frame/FrameView.h » ('j') | Source/core/frame/FrameView.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698