Add ScrollDirectionPhysical enum in Scroll types.

Source/web/WebPluginScrollbarImpl.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
  * 2.  Redistributions in binary form must reproduce the above copyright
  *     notice, this list of conditions and the following disclaimer in the
@@ skipping 199 matching lines @@
 
 void WebPluginScrollbarImpl::setDocumentSize(int size)
 {
     int length = m_scrollbar->orientation() == HorizontalScrollbar ? m_scrollbar->width() : m_scrollbar->height();
     m_scrollbar->setEnabled(size > length);
     m_scrollbar->setProportion(length, size);
 }
 
 void WebPluginScrollbarImpl::scroll(ScrollDirection direction, ScrollGranularity granularity, float multiplier)
 {
-    blink::ScrollDirection dir;
+    blink::ScrollDirectionPhysical dir;
     bool horizontal = m_scrollbar->orientation() == HorizontalScrollbar;
     if (direction == ScrollForward)
-        dir = horizontal ? ScrollRight : ScrollDown;
+        dir = horizontal ? ScrollPhysicalRight : ScrollPhysicalDown;
     else
-        dir = horizontal ? ScrollLeft : ScrollUp;
+        dir = horizontal ? ScrollPhysicalLeft : ScrollPhysicalUp;
 
     m_group->scroll(dir, static_cast<blink::ScrollGranularity>(granularity), multiplier);
 }
 
 void WebPluginScrollbarImpl::paint(WebCanvas* canvas, const WebRect& rect)
 {
     OwnPtr<GraphicsContext> context = GraphicsContext::deprecatedCreateWithCanvas(canvas);
     m_scrollbar->paint(context.get(), rect);
 }
 
@@ skipping 115 matching lines @@
 
         if (keyboard.isSystemKey || (keyboard.modifiers & WebInputEvent::ShiftKey))
             return false;
 
         keyCode = keyboard.windowsKeyCode;
     }
     blink::ScrollDirection scrollDirection;
     blink::ScrollGranularity scrollGranularity;
     if (WebViewImpl::mapKeyCodeForScroll(keyCode, &scrollDirection, &scrollGranularity)) {
         // Will return false if scroll direction wasn't compatible with this scrollbar.
-        return m_group->scroll(scrollDirection, scrollGranularity);
+        return m_group->scroll(toPhysicalDirection(scrollDirection, true, true), scrollGranularity);

[bokan, 2015/05/21 18:54:43]

I'd rather make WebViewImpl::mapKeyCodeForScroll use a ScrollDirectionPhysical.
You'll have to also update WebViewImpl::scrollViewWithKeyboard  which is the
other caller of mapKeyCodeForScroll. That method calls
EventHandler::bubblingScroll which takes ScrollDirection so I'd add a
toScrollDirection function that converts a PhysicalScrollDirection to The
ScrollLeft/Right/UpDown enums of ScrollDirection.

     }
     return false;
 }
 
 float WebPluginScrollbarImpl::elasticOverscroll() const
 {
     return m_scrollbar->elasticOverscroll();
 }
 
 void WebPluginScrollbarImpl::setElasticOverscroll(float elasticOverscroll)
 {
     m_scrollbar->setElasticOverscroll(elasticOverscroll);
 }
 
 } // namespace blink