Add ScrollDirectionPhysical enum in Scroll types.

Source/core/frame/RootFrameViewportTest.cpp

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 
 #include "core/frame/RootFrameViewport.h"
 
 #include "core/layout/ScrollAlignment.h"
 #include "platform/geometry/DoubleRect.h"
@@ skipping 173 matching lines @@
     // Disable just the layout viewport's horizontal scrolling, the
     // RootFrameViewport should remain scrollable overall.
     layoutViewport.setUserInputScrollable(false, true);
     visualViewport.setUserInputScrollable(true, true);
 
     EXPECT_TRUE(rootFrameViewport->userInputScrollable(HorizontalScrollbar));
     EXPECT_TRUE(rootFrameViewport->userInputScrollable(VerticalScrollbar));
 
     // Layout viewport shouldn't scroll since it's not horizontally scrollable,
     // but visual viewport should.
-    rootFrameViewport->scroll(ScrollRight, ScrollByPixel, 300);
+    rootFrameViewport->scroll(ScrollPhysicalRight, ScrollByPixel, 300);
     EXPECT_POINT_EQ(DoublePoint(0, 0), layoutViewport.scrollPositionDouble());
     EXPECT_POINT_EQ(DoublePoint(50, 0), visualViewport.scrollPositionDouble());
     EXPECT_POINT_EQ(DoublePoint(50, 0), rootFrameViewport->scrollPositionDouble());
 
     // Disable just the visual viewport's horizontal scrolling, only the layout
     // viewport should scroll.
     rootFrameViewport->setScrollPosition(DoublePoint());
     layoutViewport.setUserInputScrollable(true, true);
     visualViewport.setUserInputScrollable(false, true);
 
-    rootFrameViewport->scroll(ScrollRight, ScrollByPixel, 300);
+    rootFrameViewport->scroll(ScrollPhysicalRight, ScrollByPixel, 300);
     EXPECT_POINT_EQ(DoublePoint(100, 0), layoutViewport.scrollPositionDouble());
     EXPECT_POINT_EQ(DoublePoint(0, 0), visualViewport.scrollPositionDouble());
     EXPECT_POINT_EQ(DoublePoint(100, 0), rootFrameViewport->scrollPositionDouble());
 
     // Disable both viewports' horizontal scrolling, all horizontal scrolling
     // should now be blocked.
     rootFrameViewport->setScrollPosition(DoublePoint());
     layoutViewport.setUserInputScrollable(false, true);
     visualViewport.setUserInputScrollable(false, true);
 
-    rootFrameViewport->scroll(ScrollRight, ScrollByPixel, 300);
+    rootFrameViewport->scroll(ScrollPhysicalRight, ScrollByPixel, 300);
     EXPECT_POINT_EQ(DoublePoint(0, 0), layoutViewport.scrollPositionDouble());
     EXPECT_POINT_EQ(DoublePoint(0, 0), visualViewport.scrollPositionDouble());
     EXPECT_POINT_EQ(DoublePoint(0, 0), rootFrameViewport->scrollPositionDouble());
 
     EXPECT_FALSE(rootFrameViewport->userInputScrollable(HorizontalScrollbar));
     EXPECT_TRUE(rootFrameViewport->userInputScrollable(VerticalScrollbar));
 
     // Vertical scrolling should be unaffected.
-    rootFrameViewport->scroll(ScrollDown, ScrollByPixel, 300);
+    rootFrameViewport->scroll(ScrollPhysicalDown, ScrollByPixel, 300);
     EXPECT_POINT_EQ(DoublePoint(0, 150), layoutViewport.scrollPositionDouble());
     EXPECT_POINT_EQ(DoublePoint(0, 75), visualViewport.scrollPositionDouble());
     EXPECT_POINT_EQ(DoublePoint(0, 225), rootFrameViewport->scrollPositionDouble());
 
     // Try the same checks as above but for the vertical direction.
     // ===============================================
 
     rootFrameViewport->setScrollPosition(DoublePoint());
 
     // Disable just the layout viewport's vertical scrolling, the
     // RootFrameViewport should remain scrollable overall.
     layoutViewport.setUserInputScrollable(true, false);
     visualViewport.setUserInputScrollable(true, true);
 
     EXPECT_TRUE(rootFrameViewport->userInputScrollable(HorizontalScrollbar));
     EXPECT_TRUE(rootFrameViewport->userInputScrollable(VerticalScrollbar));
 
     // Layout viewport shouldn't scroll since it's not vertically scrollable,
     // but visual viewport should.
-    rootFrameViewport->scroll(ScrollDown, ScrollByPixel, 300);
+    rootFrameViewport->scroll(ScrollPhysicalDown, ScrollByPixel, 300);
     EXPECT_POINT_EQ(DoublePoint(0, 0), layoutViewport.scrollPositionDouble());
     EXPECT_POINT_EQ(DoublePoint(0, 75), visualViewport.scrollPositionDouble());
     EXPECT_POINT_EQ(DoublePoint(0, 75), rootFrameViewport->scrollPositionDouble());
 
     // Disable just the visual viewport's vertical scrolling, only the layout
     // viewport should scroll.
     rootFrameViewport->setScrollPosition(DoublePoint());
     layoutViewport.setUserInputScrollable(true, true);
     visualViewport.setUserInputScrollable(true, false);
 
-    rootFrameViewport->scroll(ScrollDown, ScrollByPixel, 300);
+    rootFrameViewport->scroll(ScrollPhysicalDown, ScrollByPixel, 300);
     EXPECT_POINT_EQ(DoublePoint(0, 150), layoutViewport.scrollPositionDouble());
     EXPECT_POINT_EQ(DoublePoint(0, 0), visualViewport.scrollPositionDouble());
     EXPECT_POINT_EQ(DoublePoint(0, 150), rootFrameViewport->scrollPositionDouble());
 
     // Disable both viewports' horizontal scrolling, all vertical scrolling
     // should now be blocked.
     rootFrameViewport->setScrollPosition(DoublePoint());
     layoutViewport.setUserInputScrollable(true, false);
     visualViewport.setUserInputScrollable(true, false);
 
-    rootFrameViewport->scroll(ScrollDown, ScrollByPixel, 300);
+    rootFrameViewport->scroll(ScrollPhysicalDown, ScrollByPixel, 300);
     EXPECT_POINT_EQ(DoublePoint(0, 0), layoutViewport.scrollPositionDouble());
     EXPECT_POINT_EQ(DoublePoint(0, 0), visualViewport.scrollPositionDouble());
     EXPECT_POINT_EQ(DoublePoint(0, 0), rootFrameViewport->scrollPositionDouble());
 
     EXPECT_TRUE(rootFrameViewport->userInputScrollable(HorizontalScrollbar));
     EXPECT_FALSE(rootFrameViewport->userInputScrollable(VerticalScrollbar));
 
     // Horizontal scrolling should be unaffected.
-    rootFrameViewport->scroll(ScrollRight, ScrollByPixel, 300);
+    rootFrameViewport->scroll(ScrollPhysicalRight, ScrollByPixel, 300);
     EXPECT_POINT_EQ(DoublePoint(100, 0), layoutViewport.scrollPositionDouble());
     EXPECT_POINT_EQ(DoublePoint(50, 0), visualViewport.scrollPositionDouble());
     EXPECT_POINT_EQ(DoublePoint(150, 0), rootFrameViewport->scrollPositionDouble());
 }
 
 // Make sure scrolls using the scroll animator (scroll(), setScrollPosition(), wheelHandler)
 // work correctly when one of the subviewports is explicitly scrolled without using the
 // RootFrameViewport interface.
 TEST_F(RootFrameViewportTest, TestScrollAnimatorUpdatedBeforeScroll)
 {
@@ skipping 12 matching lines @@
     // If the scroll animator doesn't update, it will still think it's at (0, 0) and so it
     // may early exit.
     rootFrameViewport->setScrollPosition(DoublePoint(0, 0));
     EXPECT_POINT_EQ(DoublePoint(0, 0), rootFrameViewport->scrollPositionDouble());
     EXPECT_POINT_EQ(DoublePoint(0, 0), visualViewport.scrollPositionDouble());
 
     // Try again for scroll()
     visualViewport.setScrollPosition(DoublePoint(50, 75));
     EXPECT_POINT_EQ(DoublePoint(50, 75), rootFrameViewport->scrollPositionDouble());
 
-    rootFrameViewport->scroll(ScrollLeft, ScrollByPixel, 50);
+    rootFrameViewport->scroll(ScrollPhysicalLeft, ScrollByPixel, 50);
     EXPECT_POINT_EQ(DoublePoint(0, 75), rootFrameViewport->scrollPositionDouble());
     EXPECT_POINT_EQ(DoublePoint(0, 75), visualViewport.scrollPositionDouble());
 
     // Try again for handleWheel.
     visualViewport.setScrollPosition(DoublePoint(50, 75));
     EXPECT_POINT_EQ(DoublePoint(50, 75), rootFrameViewport->scrollPositionDouble());
 
     PlatformWheelEvent wheelEvent(
         IntPoint(10, 10), IntPoint(10, 10),
         50, 75,
         0, 0,
         ScrollByPixelWheelEvent,
         false, false, false, false);
     rootFrameViewport->handleWheel(wheelEvent);
     EXPECT_POINT_EQ(DoublePoint(0, 0), rootFrameViewport->scrollPositionDouble());
     EXPECT_POINT_EQ(DoublePoint(0, 0), visualViewport.scrollPositionDouble());
 
     // Make sure the layout viewport is also accounted for.
     layoutViewport.setScrollPosition(DoublePoint(100, 150));
     EXPECT_POINT_EQ(DoublePoint(100, 150), rootFrameViewport->scrollPositionDouble());
 
-    rootFrameViewport->scroll(ScrollLeft, ScrollByPixel, 100);
+    rootFrameViewport->scroll(ScrollPhysicalLeft, ScrollByPixel, 100);
     EXPECT_POINT_EQ(DoublePoint(0, 150), rootFrameViewport->scrollPositionDouble());
     EXPECT_POINT_EQ(DoublePoint(0, 150), layoutViewport.scrollPositionDouble());
 }
 
 // Test that the scrollIntoView correctly scrolls the main frame
 // and pinch viewports such that the given rect is centered in the viewport.
 TEST_F(RootFrameViewportTest, ScrollIntoView)
 {
     IntSize viewportSize(100, 150);
     RootFrameViewStub layoutViewport(viewportSize, IntSize(200, 300));
@@ skipping 152 matching lines @@
     ScrollResult result = rootFrameViewport->handleWheel(wheelEvent);
 
     EXPECT_TRUE(result.didScroll);
     EXPECT_POINT_EQ(DoublePoint(50, 50), visualViewport.scrollPositionDouble());
     EXPECT_POINT_EQ(DoublePoint(100, 200), layoutViewport.scrollPositionDouble());
     EXPECT_EQ(-350, result.unusedScrollDeltaX);
     EXPECT_EQ(-250, result.unusedScrollDeltaY);
 }
 
 } // namespace blink