Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(857)

Issue 1147273002: Fix typo in standalone.gypi (Closed)

Created:
5 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 7 months ago
Reviewers:
vogelheim
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Fix typo in standalone.gypi without the % we can't override the value which makes the Makefile thing not work R=vogelheim@chromium.org LOG=n BUG=none Committed: https://crrev.com/9ebf94c8e8221c75e21e54c2efe420bcfa2ed31d Cr-Commit-Position: refs/heads/master@{#28553}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/standalone.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
jochen (gone - plz use gerrit)
5 years, 7 months ago (2015-05-21 12:38:18 UTC) #1
vogelheim
lgtm gyp is magic.
5 years, 7 months ago (2015-05-21 12:49:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147273002/1
5 years, 7 months ago (2015-05-21 12:49:38 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-21 13:13:29 UTC) #5
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 13:13:37 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9ebf94c8e8221c75e21e54c2efe420bcfa2ed31d
Cr-Commit-Position: refs/heads/master@{#28553}

Powered by Google App Engine
This is Rietveld 408576698