Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(40)

Issue 1147263005: MSE: Unhide potential flakiness in duration and redundant seek tests (Closed)

Created:
4 years, 11 months ago by wolenetz
Modified:
4 years, 11 months ago
Reviewers:
tkent
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

MSE: Unhide potential flakiness in duration and redundant seek tests This CL fixes the hiding of potential real flakiness for two MSE layout tests. These two tests are guaranteed to fail since their expectations were not updated along with Blink r195852 (which changed how testharness-js reports are generated and compared). Any that all PASS no longer need an explicit expectation. If there is an explicit expectation for a testharness-js layout test, it needs some additional header and footer. Since both of these tests should succeed (though might be flaky still), this change removes their explicit PASS expectation files. BUG=418324, 309184, 303419, 284782 R=tkent@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196414

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -9 lines) Patch
D LayoutTests/http/tests/media/media-source/mediasource-duration-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
D LayoutTests/http/tests/media/media-source/mediasource-redundant-seek-expected.txt View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147263005/1
4 years, 11 months ago (2015-06-03 03:53:27 UTC) #2
wolenetz
Please take a look at patch set 1. I'd like to fix the real flakiness, ...
4 years, 11 months ago (2015-06-03 03:53:44 UTC) #3
tkent
lgtm
4 years, 11 months ago (2015-06-03 03:57:50 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/64934)
4 years, 11 months ago (2015-06-03 06:52:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147263005/1
4 years, 11 months ago (2015-06-03 15:35:59 UTC) #8
commit-bot: I haz the power
4 years, 11 months ago (2015-06-03 16:33:43 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196414

Powered by Google App Engine
This is Rietveld 408576698