Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Issue 1147263004: Service Worker: Clients.matchAll() IDL nit (Closed)

Created:
5 years, 6 months ago by jungkees
Modified:
5 years, 6 months ago
Reviewers:
falken, kinuko
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Service Worker: Clients.matchAll() IDL nit Make the returned promise's type of Clients.matchAll() method non-nullable. Spec: https://slightlyoff.github.io/ServiceWorker/spec/service_worker/index.html#clients-interface BUG=N/A Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196394

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/modules/serviceworkers/Clients.idl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
jungkees
IDL nit per spec. The caller of the callback (ServiceWorkerScriptContext::OnDidGetClients) is passing an empty vector ...
5 years, 6 months ago (2015-06-03 02:10:13 UTC) #2
kinuko
lgtm
5 years, 6 months ago (2015-06-03 05:58:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147263004/1
5 years, 6 months ago (2015-06-03 07:10:42 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/64972)
5 years, 6 months ago (2015-06-03 10:07:44 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147263004/1
5 years, 6 months ago (2015-06-03 10:24:20 UTC) #9
commit-bot: I haz the power
5 years, 6 months ago (2015-06-03 11:33:51 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196394

Powered by Google App Engine
This is Rietveld 408576698