Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 1147253004: [turbofan] Fix type feedback for JSStoreNamed (Closed)

Created:
5 years, 7 months ago by Jakob Kummerow
Modified:
5 years, 7 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Fix type feedback for JSStoreNamed And delete remnants of non-vectorized LoadICs from the type feedback oracle Committed: https://crrev.com/1fb83a2f02f8eec5d9f6b041ecf2edfdf143cdce Cr-Commit-Position: refs/heads/master@{#28650}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -28 lines) Patch
M src/compiler/js-type-feedback.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/type-info.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/type-info.cc View 2 chunks +0 lines, -21 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Jakob Kummerow
PTAL.
5 years, 7 months ago (2015-05-27 08:02:19 UTC) #2
Benedikt Meurer
LGTM.
5 years, 7 months ago (2015-05-27 12:07:02 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147253004/1
5 years, 7 months ago (2015-05-27 12:07:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-27 12:30:39 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-27 12:30:59 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1fb83a2f02f8eec5d9f6b041ecf2edfdf143cdce
Cr-Commit-Position: refs/heads/master@{#28650}

Powered by Google App Engine
This is Rietveld 408576698