Source/modules/bluetooth/BluetoothGATTCharacteristic.idl - Issue 1147243004: bluetooth: readValue Blink implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/bluetooth/BluetoothGATTCharacteristic.idl

Issue 1147243004: bluetooth: readValue Blink implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@bluetooth-read-value-interface

Patch Set: Fix Web Exposed Layout Test Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/bluetooth/BluetoothGATTCharacteristic.cpp ('k') | Source/modules/bluetooth/ConvertWebVectorToArrayBuffer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/bluetooth/BluetoothGATTCharacteristic.idl

diff --git a/Source/modules/bluetooth/BluetoothGATTCharacteristic.idl b/Source/modules/bluetooth/BluetoothGATTCharacteristic.idl

index 2aed3712d7b1190d3cfe6c4bcec21024265fd3f7..5f51c368d5fa6169c018d896f08f804f6944c76e 100644

--- a/Source/modules/bluetooth/BluetoothGATTCharacteristic.idl

+++ b/Source/modules/bluetooth/BluetoothGATTCharacteristic.idl

@@ -19,7 +19,7 @@ typedef DOMString UUID;

// readonly attribute ArrayBuffer? value;

// Promise<BluetoothGATTDescriptor> getDescriptor(BluetoothDescriptorUUID descriptor);

// Promise<sequence<BluetoothGATTDescriptor>> getDescriptors(optional BluetoothDescriptorUUID descriptor);

- // Promise<ArrayBuffer> readValue();

+ [CallWith=ScriptState] Promise<ArrayBuffer> readValue();

// Promise<void> writeValue(BufferSource value);

// Promise<void> startNotifications();

// Promise<void> stopNotifications();