bluetooth: readValue Blink implementation

Source/modules/bluetooth/BluetoothArrayBuffer.cpp

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "config.h"
+#include "modules/bluetooth/BluetoothArrayBuffer.h"
+
+#include "wtf/OwnPtr.h"
+
+namespace blink {
+
+PassRefPtr<DOMArrayBuffer> BluetoothArrayBuffer::take(ScriptPromiseResolver*, WebVector<uint8_t>* webVectorRawPointer)
+{
+    OwnPtr<WebVector<uint8_t>> webVector = adoptPtr(webVectorRawPointer);

[haraken, 2015/06/11 01:13:13]

OwnPtr<WebVector> looks really weird. WebVector and other Web primitives are
structs that are not supposed to be put on the heap (even if it works by
accident).

I think we should fix the CallbackPromiseAdapter before increasing such manual
lifetime management more.

nhiroki, yhirano: Any progress/plan to fix CallbackPromiseAdapter?

[ortuno, 2015/06/11 02:56:33]

Both CallbackPromiseAdapter and WebCallbacks require a T*. So I think we're
gonna have to put the vector in the heap either way.

[haraken, 2015/06/11 03:34:26]

Yeah. BTW, why do we need this OwnPtr? Can we just use
webVectorRawPointer->data() below?

[nhiroki, 2015/06/11 04:01:01]

Updated my current status in the issue:
https://code.google.com/p/chromium/issues/detail?id=493531#c7

(In summary, I need somewhat more time to complete..., sorry)

[ortuno, 2015/06/11 16:24:40]

I could but then I would have to manually delete webVectorRawPointer, right?

[haraken, 2015/06/11 23:23:53]

Ah, understood. I hope that the manual lifetime management will be fixed soon.

+
+    static_assert(sizeof(*webVector->data()) == 1, "uint8_t should be a single byte");
+
+    RefPtr<DOMArrayBuffer> domBuffer = DOMArrayBuffer::create(webVector->data(), webVector->size());
+
+    return domBuffer;
+}
+
+void BluetoothArrayBuffer::dispose(WebVector<uint8_t>* webBufferRaw)
+{
+    delete webBufferRaw;
+}
+
+} // namespace blink