bluetooth: readValue Blink implementation

Source/modules/bluetooth/BluetoothArrayBuffer.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef BluetoothArrayBuffer_h
+#define BluetoothArrayBuffer_h
+
+#include "core/dom/DOMArrayBuffer.h"
+#include "platform/heap/Handle.h"
+#include "public/platform/WebVector.h"
+
+namespace blink {
+
+class ScriptPromiseResolver;
+
+// BluetoothArrayBuffer is used with CallbackPromiseAdapter to receive
+// WebVector responses. See CallbackPromiseAdapter class comments.
+class BluetoothArrayBuffer {

[Jeffrey Yasskin, 2015/06/10 21:12:25]

Can you name this "ConvertWebVectorToArrayBuffer"? I don't think
"BluetoothArrayBuffer" conveys the type conversion that this is actually doing.

[ortuno, 2015/06/11 00:10:52]

Hmm but converting from WebVector to ArrayBuffer is not really it's purpose.
It's main purpose is to provide the interface for CallbackPromiseAdapter.

[Jeffrey Yasskin, 2015/06/11 00:31:37]

If it only needed to provide the interface for CallbackPromiseAdapter, you could
use any of the other classes that provide the same interface. ;) It has to tell
CallbackPromiseAdapter how to glue two specific types together, and it should be
named accordingly.

Most of the other argument types to CallbackPromiseAdapter and 'Thing' classes
that tell it how to convert a WebThing to Thing. This one's not telling it how
to convert to a BluetoothArrayBuffer, so I don't think that's a good name.

Maybe the *right* answer is to expose this interface on DOMArrayBuffer and then
just use that directly?

[ortuno, 2015/06/11 02:56:33]

Ah ok. That makes sense.
You mean the CallbackPromiseAdapter interface? I haven't seen any platform/
objects implement the CallbackPromiseAdapter interface.

+    WTF_MAKE_NONCOPYABLE(BluetoothArrayBuffer);
+public:
+    // Interface required by CallbackPromiseAdapter:
+    typedef WebVector<uint8_t> WebType;
+    static PassRefPtr<DOMArrayBuffer> take(ScriptPromiseResolver*, WebVector<uint8_t>*);
+    static void dispose(WebVector<uint8_t>*);
+
+private:
+    BluetoothArrayBuffer() = delete;
+};
+
+} // namespace blink
+
+#endif // BluetoothArrayBuffer_h