tools/licenses.py - Issue 114723009: Fixes duplicate listing of third party libraries in credits

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/licenses.py

Issue 114723009: Fixes duplicate listing of third party libraries in credits (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/licenses.py

diff --git a/tools/licenses.py b/tools/licenses.py

index e87a54d1682565088f01b458b7d5f7d18eda111c..cd121c2a84bf4101696a3264d715d17f6d166c64 100755

--- a/tools/licenses.py

+++ b/tools/licenses.py

@@ -366,7 +366,7 @@ def FindThirdPartyDirs(prune_paths, root):

dirs[:] = []

for dir in ADDITIONAL_PATHS:

- if dir not in prune_paths:

+ if dir not in prune_paths and dir not in third_party_dirs:

Paweł Hajdan Jr. 2013/12/18 08:48:12 nit: Could you make third_party_dirs a set instead

third_party_dirs.append(dir)

return third_party_dirs

« no previous file with comments | « no previous file | no next file » | no next file with comments »