Fixes duplicate listing of third party libraries in credits

Fixes duplicate listing of third party libraries in credits

The party license generator can return duplicate paths when a path is both
defined in ADDITIONAL_PATHS and found through the recursive scan. This patch
makes sure an additional path is not reported multiple times if it has
already been found.

BUG=329448
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=241834

[johannesa, 2013-12-18 08:38:30]

@evan, @pawel: Does this patch look OK to you?

[Paweł Hajdan Jr., 2013-12-18 08:48:11]

The idea looks good. Just one minor implementation-level comment.

https://codereview.chromium.org/114723009/diff/1/tools/licenses.py
File tools/licenses.py (right):

https://codereview.chromium.org/114723009/diff/1/tools/licenses.py#newcode369
tools/licenses.py:369: if dir not in prune_paths and dir not in
third_party_dirs:
nit: Could you make third_party_dirs a set instead?

[johannesa, 2013-12-18 09:11:29]

On 2013/12/18 08:48:11, Paweł Hajdan Jr. wrote:
> The idea looks good. Just one minor implementation-level comment.
> 
> https://codereview.chromium.org/114723009/diff/1/tools/licenses.py
> File tools/licenses.py (right):
> 
> https://codereview.chromium.org/114723009/diff/1/tools/licenses.py#newcode369
> tools/licenses.py:369: if dir not in prune_paths and dir not in
> third_party_dirs:
> nit: Could you make third_party_dirs a set instead?

Yes. This is a good idea. I'll submit a new patch.

[Paweł Hajdan Jr., 2013-12-18 09:38:04]

LGTM

[commit-bot: I haz the power, 2013-12-19 07:45:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/johannesa@opera.com/114723009/10001

[commit-bot: I haz the power, 2013-12-19 10:09:24]

Change committed as 241834