Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 1147223006: Rename internal Dart content handler unit testing library to _testing (Closed)

Created:
5 years, 7 months ago by Cutch
Modified:
5 years, 7 months ago
Reviewers:
APW, eseidel1
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Rename internal Dart content handler unit testing library to _testing - Also, fix clean builds, by not including the sdk_ext_directory as an input dependency because there is no rule to create it. Committed: https://chromium.googlesource.com/external/mojo/+/d610ed3d266c2a06af0dc855b92373c2a5447181

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -10 lines) Patch
M mojo/dart/test/bindings_generation_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/test/codec_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/test/compile_all_interfaces_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/test/control_messages_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/test/core_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/test/handle_finalizer_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/test/handle_watcher_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/test/validation_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M mojo/dart/testing/pubspec.yaml View 1 chunk +2 lines, -1 line 0 comments Download
M mojo/public/dart/rules.gni View 1 1 chunk +1 line, -1 line 0 comments Download
M sky/sdk/BUILD.gn View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Cutch
5 years, 7 months ago (2015-05-21 16:24:29 UTC) #2
Cutch
TBR
5 years, 7 months ago (2015-05-21 16:55:30 UTC) #3
Cutch
Committed patchset #2 (id:20001) manually as d610ed3d266c2a06af0dc855b92373c2a5447181.
5 years, 7 months ago (2015-05-21 16:56:03 UTC) #4
APW
5 years, 7 months ago (2015-05-21 16:57:57 UTC) #5
Message was sent while issue was closed.
On 2015/05/21 16:56:03, Cutch wrote:
> Committed patchset #2 (id:20001) manually as
> d610ed3d266c2a06af0dc855b92373c2a5447181.

lgtm

Powered by Google App Engine
This is Rietveld 408576698