Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(297)

Issue 1147223002: Log serial read and write errors on Windows. (Closed)

Created:
5 years, 7 months ago by Reilly Grant (use Gerrit)
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Log serial read and write errors on Windows. Log platform errors so that it is possible to determine from logs what caused the chrome.serial API to return the generic "system_error" message. Committed: https://crrev.com/114441175e97285f358623c493a39710b9613ff2 Cr-Commit-Position: refs/heads/master@{#330870}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M device/serial/serial_io_handler_win.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Reilly Grant (use Gerrit)
Ken, please take a look.
5 years, 7 months ago (2015-05-21 00:29:20 UTC) #2
Ken Rockot(use gerrit already)
lgtm
5 years, 7 months ago (2015-05-21 00:30:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147223002/1
5 years, 7 months ago (2015-05-21 01:16:27 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-21 01:38:54 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-21 01:39:46 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/114441175e97285f358623c493a39710b9613ff2
Cr-Commit-Position: refs/heads/master@{#330870}

Powered by Google App Engine
This is Rietveld 408576698