Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9208)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/child_process_launcher.cc

Issue 1147213004: Store and load icudtl.dat directly from the apk rather than extracting on start-up (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@load-from-apk
Patch Set: CHECK(fd > 0) -> CHECK_GE(fd, 0) Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/chrome_content_browser_client.cc ('K') | « components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsApplication.java ('k') | content/public/browser/content_browser_client.h » ('j') | content/public/browser/content_browser_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/child_process_launcher.cc
diff --git a/content/browser/child_process_launcher.cc b/content/browser/child_process_launcher.cc
index 67f17a218928b829d7f9f48ce930f290ee57b8f4..9700a024f8da280940e10e93c78e79012b94c493 100644
--- a/content/browser/child_process_launcher.cc
+++ b/content/browser/child_process_launcher.cc
@@ -146,7 +146,7 @@ void LaunchOnLauncherThread(const NotifyCallback& callback,
CHECK(!cmd_line->HasSwitch(switches::kSingleProcess));
std::map<int, base::MemoryMappedFile::Region> regions;
GetContentClient()->browser()->GetAdditionalMappedFilesForChildProcess(
- *cmd_line, child_process_id, files_to_register.get());
+ *cmd_line, child_process_id, files_to_register.get(), &regions);
StartChildProcess(
cmd_line->argv(), child_process_id, files_to_register.Pass(), regions,
« chrome/browser/chrome_content_browser_client.cc ('K') | « components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsApplication.java ('k') | content/public/browser/content_browser_client.h » ('j') | content/public/browser/content_browser_client.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698