chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastApplication.java - Issue 1147213004: Store and load icudtl.dat directly from the apk rather than extracting on start-up

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastApplication.java

Issue 1147213004: Store and load icudtl.dat directly from the apk rather than extracting on start-up (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@load-from-apk

Patch Set: Review comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/i18n/icu_util.cc ('K') | « chrome/browser/chrome_content_browser_client.cc ('k') | components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsApplication.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastApplication.java

diff --git a/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastApplication.java b/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastApplication.java

index b4ba4f0ef48c9a9aa945b8519347ce8299ebf529..903609f4733dd89627a7852ca59211f6ffb1d79a 100644

--- a/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastApplication.java

+++ b/chromecast/browser/android/apk/src/org/chromium/chromecast/shell/CastApplication.java

@@ -26,7 +26,6 @@ public class CastApplication extends ContentApplication {

private static final String[] MANDATORY_PAK_FILES = new String[] {

"cast_shell.pak",

- "icudtl.dat",

};

private static final String PRIVATE_DATA_DIRECTORY_SUFFIX = "cast_shell";

private static final String COMMAND_LINE_FILE = "/data/local/tmp/castshell-command-line";