chrome/browser/chrome_content_browser_client.h - Issue 1147213004: Store and load icudtl.dat directly from the apk rather than extracting on start-up

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chrome_content_browser_client.h

Issue 1147213004: Store and load icudtl.dat directly from the apk rather than extracting on start-up (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@load-from-apk

Patch Set: Review comments Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/i18n/icu_util.cc ('K') | « chrome/android/shell/java/src/org/chromium/chrome/shell/ChromeShellApplication.java ('k') | chrome/browser/chrome_content_browser_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chrome_content_browser_client.h

diff --git a/chrome/browser/chrome_content_browser_client.h b/chrome/browser/chrome_content_browser_client.h

index cd15dfdb734590b91e9f31cd54f1620e976d24af..3e20f6fe7db604e152a9ebf32978eebe468d37e0 100644

--- a/chrome/browser/chrome_content_browser_client.h

+++ b/chrome/browser/chrome_content_browser_client.h

@@ -310,6 +310,10 @@ class ChromeContentBrowserClient : public content::ContentBrowserClient {

#if defined(OS_POSIX) && !defined(OS_MACOSX)

gin::V8Initializer::V8Files v8_files_;

#endif // OS_POSIX && !OS_MACOSX

+#if defined(OS_ANDROID)

+ base::ScopedFD icudtl_fd_;

+ base::MemoryMappedFile::Region icudtl_region_;

+#endif

// Vector of additional ChromeContentBrowserClientParts.

// Parts are deleted in the reverse order they are added.