components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsApplication.java - Issue 1147213004: Store and load icudtl.dat directly from the apk rather than extracting on start-up

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsApplication.java

Issue 1147213004: Store and load icudtl.dat directly from the apk rather than extracting on start-up (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@load-from-apk

Patch Set: Keep extracting for components/ Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chromecast/browser/cast_content_browser_client.cc ('K') | « chromecast/browser/cast_content_browser_client.cc ('k') | content/browser/battery_status/battery_monitor_integration_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsApplication.java

diff --git a/components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsApplication.java b/components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsApplication.java

index 91ee597b9e6984623986b9b4bcafe810d15d0048..fba6126987c023d61d12d4a386bb2130dc23657f 100644

--- a/components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsApplication.java

+++ b/components/test/android/browsertests_apk/src/org/chromium/components_browsertests_apk/ComponentsBrowserTestsApplication.java

@@ -14,6 +14,8 @@ import org.chromium.base.ResourceExtractor;

* A basic content browser tests {@link android.app.Application}.

public class ComponentsBrowserTestsApplication extends BaseChromiumApplication {

+ // TODO(agrieve): These should be loaded directly from the .apk (mmap'ed)

+ // rather than extracted.

private static final String[] MANDATORY_PAK_FILES =

new String[] {"components_tests_resources.pak", "content_shell.pak", "icudtl.dat",

"natives_blob.bin", "snapshot_blob.bin"};