ash/shell/content_client/shell_content_browser_client.cc - Issue 1147213004: Store and load icudtl.dat directly from the apk rather than extracting on start-up

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/shell/content_client/shell_content_browser_client.cc

Issue 1147213004: Store and load icudtl.dat directly from the apk rather than extracting on start-up (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@load-from-apk

Patch Set: Keep extracting for components/ Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/shell/content_client/shell_content_browser_client.cc

diff --git a/ash/shell/content_client/shell_content_browser_client.cc b/ash/shell/content_client/shell_content_browser_client.cc

index 51b0107d5ad9f1b8a532e3793655f9a506b1f193..06d2eba738ff7d5d00a4891927f3dd277b4bcb50 100644

--- a/ash/shell/content_client/shell_content_browser_client.cc

+++ b/ash/shell/content_client/shell_content_browser_client.cc

@@ -62,7 +62,11 @@ void ShellContentBrowserClient::AppendExtraCommandLineSwitches(

void ShellContentBrowserClient::GetAdditionalMappedFilesForChildProcess(

const base::CommandLine& command_line,

int child_process_id,

- content::FileDescriptorInfo* mappings) {

+ content::FileDescriptorInfo* mappings

+#if defined(OS_ANDROID)

+ , std::map<int, base::MemoryMappedFile::Region>* regions

+#endif

+ ) {

#if defined(V8_USE_EXTERNAL_STARTUP_DATA)

if (v8_natives_fd_.get() == -1 || v8_snapshot_fd_.get() == -1) {

int v8_natives_fd = -1;

« no previous file with comments | « ash/shell/content_client/shell_content_browser_client.h ('k') | base/i18n/icu_util.h » ('j') | base/i18n/icu_util.cc » ('J')