Store and load icudtl.dat directly from the apk rather than extracting on start-up

chromecast/browser/cast_content_browser_client.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromecast/browser/cast_content_browser_client.h"
 
 #include <string>
 
 #include "base/base_switches.h"
 #include "base/command_line.h"
@@ skipping 296 matching lines @@
     int render_process_id,
     int opener_id,
     bool* no_javascript_access) {
   *no_javascript_access = true;
   return false;
 }
 
 void CastContentBrowserClient::GetAdditionalMappedFilesForChildProcess(
     const base::CommandLine& command_line,
     int child_process_id,
-    content::FileDescriptorInfo* mappings) {
+    content::FileDescriptorInfo* mappings
+#if defined(OS_ANDROID)
+    , std::map<int, base::MemoryMappedFile::Region>* regions
+#endif
+    ) {
 #if defined(V8_USE_EXTERNAL_STARTUP_DATA)
   if (v8_natives_fd_.get() == -1 || v8_snapshot_fd_.get() == -1) {
     int v8_natives_fd = -1;
     int v8_snapshot_fd = -1;
     if (gin::V8Initializer::OpenV8FilesForChildProcesses(&v8_natives_fd,
                                                          &v8_snapshot_fd)) {
       v8_natives_fd_.reset(v8_natives_fd);
       v8_snapshot_fd_.reset(v8_snapshot_fd);
     }
   }
@@ skipping 27 matching lines @@
   }
 
   base::FilePath app_data_path;
   CHECK(PathService::Get(base::DIR_ANDROID_APP_DATA, &app_data_path));
   base::FilePath icudata_path =
       app_data_path.AppendASCII(base::i18n::kIcuDataFileName);
   base::File icudata_file(icudata_path, flags_open_read);
   if (!icudata_file.IsValid())
     NOTREACHED() << "Failed to open ICU file when creating renderer process";
   mappings->Transfer(kAndroidICUDataDescriptor,
                      base::ScopedFD(icudata_file.TakePlatformFile()));

[jungshik at Google, 2015/06/09 23:45:15]

I'm wondering why this file does not require the same change as
chrome_content_browser.cc. 

 #else
   int crash_signal_fd = GetCrashSignalFD(command_line);
   if (crash_signal_fd >= 0) {
     mappings->Share(kCrashDumpSignal, crash_signal_fd);
   }
 #endif  // defined(OS_ANDROID)
 }
 
 #if defined(OS_ANDROID) && defined(VIDEO_HOLE)
 content::ExternalVideoSurfaceContainer*
@@ skipping 38 matching lines @@
         process_type, dumps_path, false /* upload */);
   // StartUploaderThread() even though upload is diferred.
   // Breakpad-related memory is freed in the uploader thread.
   crash_handler->StartUploaderThread();
   return crash_handler;
 }
 #endif  // !defined(OS_ANDROID)
 
 }  // namespace shell
 }  // namespace chromecast