utils/pub/command_lish.dart - Issue 11472033: Fix "src" detection in the pub lish validator on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: utils/pub/command_lish.dart

Issue 11472033: Fix "src" detection in the pub lish validator on Windows. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: utils/pub/command_lish.dart

diff --git a/utils/pub/command_lish.dart b/utils/pub/command_lish.dart

index 55237e94396c3a46493af4ac5d898adf4f9b1c9e..53fb3a905a19ada954c9fb4beb86c319710f098b 100644

--- a/utils/pub/command_lish.dart

+++ b/utils/pub/command_lish.dart

@@ -142,6 +142,8 @@ class LishCommand extends PubCommand {

if (file == null || _BLACKLISTED_FILES.contains(basename(file))) {

return false;

}

+ // TODO(nweiz): Since `file` is absolute, this will break if the package

+ // itself is in a directory named "packages".

Bob Nystrom 2012/12/07 21:28:39 File a bug for this?

nweiz 2012/12/07 21:33:31 Done.

return !splitPath(file).some(_BLACKLISTED_DIRECTORIES.contains);

}));

}

« no previous file with comments | « no previous file | utils/pub/validator/name.dart » ('j') | no next file with comments »