Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(524)

Issue 1147203002: Revert of Changes caching logic of mojo java apps (Closed)

Created:
5 years, 7 months ago by sky
Modified:
5 years, 7 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Changes caching logic of mojo java apps (patchset #5 id:80001 of https://codereview.chromium.org/1149813002/) Reason for revert: Broke windows build. Original issue's description: > Changes caching logic of mojo java apps > > Previously we would extract all necessary files every time we ran the > app. This is obviously unnecessary for any bundled apps. Now we > extract only as necessary. > > R=ben@chromium.org, jcivelli@chromium.org > BUG=none > TEST=none > > Committed: https://crrev.com/128f7a0181634a89a35f681baab1d086d100e377 > Cr-Commit-Position: refs/heads/master@{#330824} TBR=ben@chromium.org,jcivelli@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=none Committed: https://crrev.com/f8e129988d5af0fe5fed283a9baa03a185ec61ab Cr-Commit-Position: refs/heads/master@{#330832}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -354 lines) Patch
M mojo/runner/android/android_handler.cc View 4 chunks +4 lines, -76 lines 0 comments Download
M mojo/runner/android/apk/src/org/chromium/mojo/shell/AndroidHandler.java View 3 chunks +23 lines, -146 lines 0 comments Download
M mojo/runner/android/apk/src/org/chromium/mojo/shell/Bootstrap.java View 2 chunks +3 lines, -5 lines 0 comments Download
M mojo/runner/android/apk/src/org/chromium/mojo/shell/FileHelper.java View 4 chunks +55 lines, -92 lines 0 comments Download
M mojo/runner/android/apk/src/org/chromium/mojo/shell/ShellMain.java View 4 chunks +4 lines, -9 lines 0 comments Download
M mojo/runner/android/bootstrap.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M mojo/runner/android/run_android_application_function.h View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/runner/android/tests/src/org/chromium/mojo/shell/ShellTestBase.java View 1 chunk +1 line, -2 lines 0 comments Download
M mojo/runner/url_resolver.cc View 1 chunk +3 lines, -7 lines 0 comments Download
M mojo/runner/url_resolver_unittest.cc View 1 chunk +2 lines, -12 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
sky
Created Revert of Changes caching logic of mojo java apps
5 years, 7 months ago (2015-05-20 23:19:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147203002/1
5 years, 7 months ago (2015-05-20 23:21:37 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-20 23:23:29 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 23:24:23 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f8e129988d5af0fe5fed283a9baa03a185ec61ab
Cr-Commit-Position: refs/heads/master@{#330832}

Powered by Google App Engine
This is Rietveld 408576698