Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 11472019: Revert 171679 (Closed)

Created:
8 years ago by xiyuan
Modified:
8 years ago
Reviewers:
ccameron
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 171679 > Explicitly create the GLX window for onscreen surfaces. > > Always use glXCreateContextAttribsARB to create GLX contexts. > > This will allow us to explicitly destroy hibernated GLX windows, which will hopefully plug some GPU memory leaks that were causing instability. > > BUG=145600 > > > Review URL: https://chromiumcodereview.appspot.com/11467008 TBR=ccameron@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171698

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -37 lines) Patch
M ui/gl/gl_context_glx.cc View 3 chunks +76 lines, -17 lines 0 comments Download
M ui/gl/gl_surface_glx.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/gl/gl_surface_glx.cc View 5 chunks +5 lines, -19 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
xiyuan
8 years ago (2012-12-07 05:54:05 UTC) #1
xiyuan
8 years ago (2012-12-07 05:56:18 UTC) #2
VMTests are failing on ChromiumOS(x86) and ChromiumOS(amd64) because chrome
could not be started:
http://chromegw/i/chromium.chromiumos/builders/ChromiumOS%20%28x86%29/builds/...
http://chromegw/i/chromium.chromiumos/builders/ChromiumOS%20%28amd64%29/build...

Chrome log in archived artifacts shows the following line:
[1370:1370:1206/200810:ERROR:gl_context_glx.cc(71)] Couldn't create GL context.
[1343:1343:1206/200810:ERROR:command_buffer_proxy_impl.cc(152)] Failed to
initialize command buffer service.
[1370:1370:1206/200810:ERROR:x11_util.cc(1716)] X error received: serial 28,
error_code 1 (BadRequest (invalid request code or no such operation)),
request_code 147, minor_code 34 (Unknown)
[1343:1343:1206/200810:FATAL:image_transport_factory.cc(578)] Failed to make UI
shared context current.

Powered by Google App Engine
This is Rietveld 408576698