cc: Add receiver for CompositorFrameAck in LayerTreeHostImpl and forward it to the renderer.

cc: Add receiver for CompositorFrameAck in LayerTreeHostImpl and forward it to the renderer.

BUG=146080
R=piman

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=171895

[danakj, 2012-12-06 18:00:52]

There's a reinterpret cast in here, which will go away when
https://codereview.chromium.org/11348371 lands.

Or, we can wait for that if we're strongly against landing any reinterpret
casts.

I kept this small since that might be controversial. I'll work on a CL for
DelegatingRenderer next.

[piman, 2012-12-06 18:07:05]

https://codereview.chromium.org/11472004/diff/1/cc/layer_tree_host_impl.cc
File cc/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/11472004/diff/1/cc/layer_tree_host_impl.cc#ne...
cc/layer_tree_host_impl.cc:826: const CompositorFrameAck& ack =
reinterpret_cast<const CompositorFrameAck&>(webAck);
In the mean time, can we just make CompositorFrameAck derive from the (empty)
WebCompositorFrameAck and make this a static_cast ?

[jamesr, 2012-12-06 20:23:14]

On 2012/12/06 18:07:05, piman wrote:
> https://codereview.chromium.org/11472004/diff/1/cc/layer_tree_host_impl.cc
> File cc/layer_tree_host_impl.cc (right):
> 
>
https://codereview.chromium.org/11472004/diff/1/cc/layer_tree_host_impl.cc#ne...
> cc/layer_tree_host_impl.cc:826: const CompositorFrameAck& ack =
> reinterpret_cast<const CompositorFrameAck&>(webAck);
> In the mean time, can we just make CompositorFrameAck derive from the (empty)
> WebCompositorFrameAck and make this a static_cast ?

Please do.  This reinterpret_cast<> is almost certainly UB

[danakj, 2012-12-07 19:13:47]

Rebased on https://chromiumcodereview.appspot.com/11348371/ which is in the CQ.

PTAL

[piman, 2012-12-07 19:51:56]

lgtm

[commit-bot: I haz the power, 2012-12-07 21:48:11]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/danakj@chromium.org/11472004/4002