Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 1147163003: Revert of Roll DEPS to class-dump 3.5 (Closed)

Created:
5 years, 7 months ago by sgurun-gerrit only
Modified:
5 years, 7 months ago
CC:
chromium-reviews, smut, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Roll DEPS to class-dump 3.5 (patchset #4 id:60001 of https://codereview.chromium.org/1106993002/) Reason for revert: Breaking https://build.chromium.org/p/chromium.mac/builders/iOS_Device/builds/7076 Original issue's description: > Roll DEPS to class-dump 3.5 > > Removes some build warnings. > > Moves the class-dump repo to a github auto-mirror instead of a mirror > that needs to be manually updated. > > This also requires that the class-dump.gyp file move from the > third-party repo into the main source tree. Note that the file > structure of the class-dump source changed so the .gyp had to be > updated. For comparison, the old .class-dump.gyp can be found at > https://chromium.googlesource.com/chromium/deps/class-dump/+/master/class-dump.gyp > > BUG=318160 > > Committed: https://crrev.com/1c80791ce7c29a29fc816d89d1a5fa2ac6503b3e > Cr-Commit-Position: refs/heads/master@{#330798} TBR=justincohen@chromium.org,rohitrao@chromium.org,lliabraa@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=318160 Committed: https://crrev.com/b9d760ae212ab40c630a7c68e9eb27bae3bfab7a Cr-Commit-Position: refs/heads/master@{#330804}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -191 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
D testing/iossim/class-dump.gyp View 1 chunk +0 lines, -189 lines 0 comments Download
M testing/iossim/iossim.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
sgurun-gerrit only
Created Revert of Roll DEPS to class-dump 3.5
5 years, 7 months ago (2015-05-20 21:16:20 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147163003/1
5 years, 7 months ago (2015-05-20 21:17:09 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-20 21:24:02 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b9d760ae212ab40c630a7c68e9eb27bae3bfab7a Cr-Commit-Position: refs/heads/master@{#330804}
5 years, 7 months ago (2015-05-20 21:25:42 UTC) #4
smut
+cc stuartmorgan, jam: Original CL passed iOS's ninja try bots. Another entry for https://goto.google.com/ninja-xcode-differences?
5 years, 7 months ago (2015-05-20 21:41:41 UTC) #5
stuartmorgan
5 years, 7 months ago (2015-05-20 21:50:19 UTC) #6
Message was sent while issue was closed.
On 2015/05/20 21:41:41, smut wrote:
> +cc stuartmorgan, jam: Original CL passed iOS's ninja try bots. Another entry
> for https://goto.google.com/ninja-xcode-differences

I can't tell without knowing more about why it failed. Did we somehow apply
chromium_code settings to the target?

Powered by Google App Engine
This is Rietveld 408576698