tests/CachedDecodingPixelRefTest.cpp - Issue 1147153004: add assert that the lock-count on pixelref is balanced

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/CachedDecodingPixelRefTest.cpp

Issue 1147153004: add assert that the lock-count on pixelref is balanced (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/CachedDecodingPixelRefTest.cpp

diff --git a/tests/CachedDecodingPixelRefTest.cpp b/tests/CachedDecodingPixelRefTest.cpp

index 670d849436f5a11a17adbbb0cbbc2051f11139cf..66e5273625df385d772cc33e666a7fbff6df5a1e 100644

--- a/tests/CachedDecodingPixelRefTest.cpp

+++ b/tests/CachedDecodingPixelRefTest.cpp

@@ -262,11 +262,13 @@ static void check_pixelref(TestImageGenerator::TestType type,

robertphillips 2015/05/21 13:32:04 // TODO: remove this test ?

// new/lock/delete is an odd pattern for a pixelref, but it needs to not assert

static void test_newlockdelete(skiatest::Reporter* reporter) {

+#ifdef SK_SUPPORT_LEGACY_UNBALANCED_PIXELREF_LOCKCOUNT

SkBitmap bm;

SkImageGenerator* ig = new TestImageGenerator(

TestImageGenerator::kSucceedGetPixels_TestType, reporter);

SkInstallDiscardablePixelRef(ig, &bm);

bm.pixelRef()->lockPixels();

+#endif

}

/**