Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1147153004: add assert that the lock-count on pixelref is balanced (Closed)

Created:
5 years, 7 months ago by reed1
Modified:
5 years, 7 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

add assert that the lock-count on pixelref is balanced BUG=skia: TBR= Committed: https://skia.googlesource.com/skia/+/ab8657722c7a6676b67b0820210b288ba84a14d9

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -0 lines) Patch
M gyp/skia_for_android_framework_defines.gypi View 1 chunk +1 line, -0 lines 1 comment Download
M src/core/SkPixelRef.cpp View 2 chunks +5 lines, -0 lines 0 comments Download
M tests/CachedDecodingPixelRefTest.cpp View 1 chunk +2 lines, -0 lines 1 comment Download

Messages

Total messages: 15 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147153004/1
5 years, 7 months ago (2015-05-21 13:00:23 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-21 13:06:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147153004/1
5 years, 7 months ago (2015-05-21 13:24:34 UTC) #7
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 7 months ago (2015-05-21 13:24:35 UTC) #8
reed1
5 years, 7 months ago (2015-05-21 13:25:41 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147153004/1
5 years, 7 months ago (2015-05-21 13:28:33 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/ab8657722c7a6676b67b0820210b288ba84a14d9
5 years, 7 months ago (2015-05-21 13:29:09 UTC) #14
robertphillips
5 years, 7 months ago (2015-05-21 13:32:05 UTC) #15
Message was sent while issue was closed. 
lgtm + questions

https://codereview.chromium.org/1147153004/diff/1/gyp/skia_for_android_framew...
File gyp/skia_for_android_framework_defines.gypi (right):

https://codereview.chromium.org/1147153004/diff/1/gyp/skia_for_android_framew...
gyp/skia_for_android_framework_defines.gypi:17: 'SK_SUPPORT_LEGACY_GETDEVICE',
Don't we need this in the Chromium gypi too?

https://codereview.chromium.org/1147153004/diff/1/tests/CachedDecodingPixelRe...
File tests/CachedDecodingPixelRefTest.cpp (right):

https://codereview.chromium.org/1147153004/diff/1/tests/CachedDecodingPixelRe...
tests/CachedDecodingPixelRefTest.cpp:262: 
// TODO: remove this test ?

Powered by Google App Engine
This is Rietveld 408576698