Add a destroy method to the TabModelSelector interface.

Add a destroy method to the TabModelSelector interface.

This will handle destroying the owned tab models, which will in turn
destroy the owned tabs.

BUG=473594
Committed: https://crrev.com/55f2e3f10f0abf4f993e6bb3fab60c4e68ed49d1
Cr-Commit-Position: refs/heads/master@{#330809}

[Ted C, 2015-05-20 20:32:08]

tedchoc@chromium.org changed reviewers:
+ dtrainor@chromium.org

[Ted C, 2015-05-20 20:32:09]

PTAL

[David Trainor- moved to gerrit, 2015-05-20 20:38:23]

lgtm

https://codereview.chromium.org/1147153002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/SingleTabModel.java
(right):

https://codereview.chromium.org/1147153002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/SingleTabModel.java:76:
return 0;
This should probably be return mTab != null 0 ? INVALID_TAB_INDEX;

https://codereview.chromium.org/1147153002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorBase.java
(right):

https://codereview.chromium.org/1147153002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorBase.java:211:
public void destroy() {
Just curious if we should drop all TabModels at this point.  Doesn't have to be
this patch, but we should start thinking about it.

[Ted C, 2015-05-20 20:45:49]

https://codereview.chromium.org/1147153002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/SingleTabModel.java
(right):

https://codereview.chromium.org/1147153002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/SingleTabModel.java:76:
return 0;
On 2015/05/20 20:38:23, David Trainor wrote:
> This should probably be return mTab != null 0 ? INVALID_TAB_INDEX;

Done.

https://codereview.chromium.org/1147153002/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorBase.java
(right):

https://codereview.chromium.org/1147153002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorBase.java:211:
public void destroy() {
On 2015/05/20 20:38:23, David Trainor wrote:
> Just curious if we should drop all TabModels at this point.  Doesn't have to
be
> this patch, but we should start thinking about it.

Probably wouldn't hurt, but I do want to keep the changes here to a minimum for
cherrypickableness

[Ted C, 2015-05-20 20:49:59]

The CQ bit was checked by tedchoc@chromium.org

[Ted C, 2015-05-20 20:49:59]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org
Link to the patchset: https://codereview.chromium.org/1147153002/#ps20001
(title: "Address comments")

[commit-bot: I haz the power, 2015-05-20 20:51:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1147153002/20001

[commit-bot: I haz the power, 2015-05-20 21:37:05]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-20 21:38:04]

Patchset 2 (id:??) landed as
https://crrev.com/55f2e3f10f0abf4f993e6bb3fab60c4e68ed49d1
Cr-Commit-Position: refs/heads/master@{#330809}