Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: sky/sdk/lib/framework/rendering/box.dart

Issue 1147143005: Make Drawer in components2 work (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: fix margin Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sky/sdk/lib/framework/rendering/box.dart
diff --git a/sky/sdk/lib/framework/rendering/box.dart b/sky/sdk/lib/framework/rendering/box.dart
index 100219477b9e13b750ad812f20c20636e9065313..adb7e455fb6017d0f1dd6e3b39160e263140a35f 100644
--- a/sky/sdk/lib/framework/rendering/box.dart
+++ b/sky/sdk/lib/framework/rendering/box.dart
@@ -50,6 +50,12 @@ class BoxConstraints {
minHeight = size.height,
maxHeight = size.height;
+ BoxConstraints.loose(sky.Size size)
+ : minWidth = 0.0,
+ maxWidth = size.width,
+ minHeight = 0.0,
+ maxHeight = size.height;
+
BoxConstraints deflate(EdgeDims edges) {
assert(edges != null);
double horizontal = edges.left + edges.right;
@@ -351,9 +357,9 @@ class RenderTransform extends RenderProxyBox {
canvas.save();
canvas.concat([
Matt Perry 2015/06/03 21:29:50 We could change Canvas.concat to take a Float32Lis
Matt Perry 2015/06/03 22:15:52 Here's what it would look like: https://codereview
- storage[ 0], storage[ 1], storage[ 3],
- storage[ 4], storage[ 5], storage[ 7],
- storage[12], storage[13], storage[15],
Hixie 2015/06/03 21:39:56 Why doesn't canvas take a Matrix, the same way it
abarth-chromium 2015/06/03 22:33:42 The answer here is slightly complicated. The shor
+ storage[ 0], storage[ 4], storage[12],
+ storage[ 1], storage[ 5], storage[13],
+ storage[ 3], storage[ 7], storage[15],
]);
super.paint(canvas);
canvas.restore();

Powered by Google App Engine
This is Rietveld 408576698