Make Drawer in components2 work

Make Drawer in components2 work

This CL introduces RenderStack and fixes a number of bugs to make the Drawer in
components2 work.

R=ianh@google.com, eseidel@chromium.org

Committed: https://chromium.googlesource.com/external/mojo/+/7b21e39e18f17659805599b1415631547fa33f94

[Matt Perry, 2015-06-03 21:29:49]

mpcomplete@chromium.org changed reviewers:
+ mpcomplete@chromium.org

[Matt Perry, 2015-06-03 21:29:50]

https://codereview.chromium.org/1147143005/diff/20001/sky/sdk/lib/framework/r...
File sky/sdk/lib/framework/rendering/box.dart (right):

https://codereview.chromium.org/1147143005/diff/20001/sky/sdk/lib/framework/r...
sky/sdk/lib/framework/rendering/box.dart:359: canvas.concat([
We could change Canvas.concat to take a Float32List in the format Matrix4 uses.

[Hixie, 2015-06-03 21:39:55]

ianh@google.com changed reviewers:
+ ianh@google.com
- mpcomplete@chromium.org

[Hixie, 2015-06-03 21:39:56]

lgtm

https://codereview.chromium.org/1147143005/diff/20001/sky/sdk/lib/framework/c...
File sky/sdk/lib/framework/components2/drawer.dart (right):

https://codereview.chromium.org/1147143005/diff/20001/sky/sdk/lib/framework/c...
sky/sdk/lib/framework/components2/drawer.dart:119: decoration: new
BoxDecoration(backgroundColor: maskColor)
this will need fixing with the new api for color

https://codereview.chromium.org/1147143005/diff/20001/sky/sdk/lib/framework/c...
sky/sdk/lib/framework/components2/drawer.dart:128: desiredSize: new
sky.Size(_kWidth, double.INFINITY),
sky.Size.onlyWidth?

https://codereview.chromium.org/1147143005/diff/20001/sky/sdk/lib/framework/r...
File sky/sdk/lib/framework/rendering/box.dart (left):

https://codereview.chromium.org/1147143005/diff/20001/sky/sdk/lib/framework/r...
sky/sdk/lib/framework/rendering/box.dart:356: storage[12], storage[13],
storage[15],
Why doesn't canvas take a Matrix, the same way it takes a Rect for other things?

https://codereview.chromium.org/1147143005/diff/20001/sky/sdk/lib/framework/r...
File sky/sdk/lib/framework/rendering/stack.dart (right):

https://codereview.chromium.org/1147143005/diff/20001/sky/sdk/lib/framework/r...
sky/sdk/lib/framework/rendering/stack.dart:35: sky.Point origin = new
sky.Point(0.0, 0.0);
const

[abarth-chromium, 2015-06-03 21:52:18]

Committed patchset #3 (id:40001) manually as
7b21e39e18f17659805599b1415631547fa33f94 (presubmit successful).

[Matt Perry, 2015-06-03 22:15:52]

mpcomplete@chromium.org changed reviewers:
+ mpcomplete@chromium.org

[Matt Perry, 2015-06-03 22:15:52]

https://codereview.chromium.org/1147143005/diff/20001/sky/sdk/lib/framework/r...
File sky/sdk/lib/framework/rendering/box.dart (right):

https://codereview.chromium.org/1147143005/diff/20001/sky/sdk/lib/framework/r...
sky/sdk/lib/framework/rendering/box.dart:359: canvas.concat([
On 2015/06/03 21:29:50, Matt Perry wrote:
> We could change Canvas.concat to take a Float32List in the format Matrix4
uses.

Here's what it would look like:
https://codereview.chromium.org/1155193004/diff/20001/sky/examples/raw/painti...

The question is, should we add our own Matrix class (that maybe just calls
through to the C++ SkMatrix class) to dart:sky, or should we let the framework
handle it (using vector_math.dart like we do here)?

[abarth-chromium, 2015-06-03 22:33:43]

https://codereview.chromium.org/1147143005/diff/20001/sky/sdk/lib/framework/r...
File sky/sdk/lib/framework/rendering/box.dart (left):

https://codereview.chromium.org/1147143005/diff/20001/sky/sdk/lib/framework/r...
sky/sdk/lib/framework/rendering/box.dart:356: storage[12], storage[13],
storage[15],
On 2015/06/03 at 21:39:56, Hixie wrote:
> Why doesn't canvas take a Matrix, the same way it takes a Rect for other
things?

The answer here is slightly complicated.  The short version is that we're going
to end with two Matrix classes, one that's optimized for manipulation within the
VM and one that's optimized for talking to skia.  Currently the |concat|
function uses neither of these.  Presumably we'll want versions for each one.