Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(596)

Issue 1147143003: android: Browser compositor use_zero_copy upload (Closed)

Created:
5 years, 7 months ago by boliu
Modified:
5 years, 7 months ago
Reviewers:
no sievers
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

android: Browser compositor use_zero_copy upload This fixes a DCHECK after https://codereview.chromium.org/1149803002. Trybots didn't catch this because android trybots do not have DCHECKs turned on. BUG=484934 TBR=sievers@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/5364de185a43ad7157a8797f6c1db979f03fd918

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/browser/renderer_host/compositor_impl_android.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
boliu
TBR sievers due to unblock upstreaming
5 years, 7 months ago (2015-05-21 03:47:12 UTC) #2
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5364de185a43ad7157a8797f6c1db979f03fd918 Cr-Commit-Position: refs/heads/master@{#330880}
5 years, 7 months ago (2015-05-21 03:50:34 UTC) #3
boliu
Committed patchset #1 (id:1) manually as 5364de185a43ad7157a8797f6c1db979f03fd918 (tree was closed).
5 years, 7 months ago (2015-05-21 03:50:44 UTC) #4
no sievers
which DCHECK?
5 years, 7 months ago (2015-05-21 18:07:09 UTC) #5
boliu
5 years, 7 months ago (2015-05-21 18:08:28 UTC) #6
Message was sent while issue was closed.
On 2015/05/21 18:07:09, sievers wrote:
> which DCHECK?

https://codereview.chromium.org/1149803002/diff/120001/cc/trees/layer_tree_ho...

Powered by Google App Engine
This is Rietveld 408576698