Upgrade WebGLImageConversion to support WebGL 2 formats and types.

Upgrade WebGLImageConversion to support WebGL 2 formats and types.

This is Part I: adding enums.

BUG=497352
TEST=webgl_conformance
R=kbr@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=196612

[Zhenyao Mo, 2015-06-05 21:57:52]

kbr: please review.

[Ken Russell (switch to Gerrit), 2015-06-05 22:42:10]

Nice work. Almost perfect. LGTM with these fixes (assuming my comments are
correct).

https://codereview.chromium.org/1147123006/diff/1/Source/platform/graphics/gp...
File Source/platform/graphics/gpu/WebGLImageConversion.cpp (left):

https://codereview.chromium.org/1147123006/diff/1/Source/platform/graphics/gp...
Source/platform/graphics/gpu/WebGLImageConversion.cpp:1474: *bytesPerComponent =
sizeof(GLushort);
I think this removal is wrong. The packed UNSIGNED_SHORT formats need to set
componentsPerPixel to 1, but other type/format combinations like UNSIGNED_SHORT,
RGBA should use the original componentsPerPixel.

https://codereview.chromium.org/1147123006/diff/1/Source/platform/graphics/gp...
File Source/platform/graphics/gpu/WebGLImageConversion.cpp (right):

https://codereview.chromium.org/1147123006/diff/1/Source/platform/graphics/gp...
Source/platform/graphics/gpu/WebGLImageConversion.cpp:1655: case
GL_UNSIGNED_INT_2_10_10_10_REV:
I think these new packed integer types need to set componentsPerPixel to 1 like
the packed unsigned short types do.

[Zhenyao Mo, 2015-06-05 22:48:49]

Thanks for catching them.

https://codereview.chromium.org/1147123006/diff/1/Source/platform/graphics/gp...
File Source/platform/graphics/gpu/WebGLImageConversion.cpp (left):

https://codereview.chromium.org/1147123006/diff/1/Source/platform/graphics/gp...
Source/platform/graphics/gpu/WebGLImageConversion.cpp:1474: *bytesPerComponent =
sizeof(GLushort);
On 2015/06/05 22:42:10, Ken Russell wrote:
> I think this removal is wrong. The packed UNSIGNED_SHORT formats need to set
> componentsPerPixel to 1, but other type/format combinations like
UNSIGNED_SHORT,
> RGBA should use the original componentsPerPixel.

Done.

https://codereview.chromium.org/1147123006/diff/1/Source/platform/graphics/gp...
File Source/platform/graphics/gpu/WebGLImageConversion.cpp (right):

https://codereview.chromium.org/1147123006/diff/1/Source/platform/graphics/gp...
Source/platform/graphics/gpu/WebGLImageConversion.cpp:1655: case
GL_UNSIGNED_INT_2_10_10_10_REV:
On 2015/06/05 22:42:10, Ken Russell wrote:
> I think these new packed integer types need to set componentsPerPixel to 1
like
> the packed unsigned short types do.

Done.

[Zhenyao Mo, 2015-06-05 23:16:39]

The CQ bit was checked by zmo@chromium.org

[Zhenyao Mo, 2015-06-05 23:16:39]

The patchset sent to the CQ was uploaded after l-g-t-m from kbr@chromium.org
Link to the patchset: https://codereview.chromium.org/1147123006/#ps20001
(title: "fix")

[commit-bot: I haz the power, 2015-06-05 23:16:51]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1147123006/20001

[commit-bot: I haz the power, 2015-06-06 00:09:50]

Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=196612