Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2060)

Unified Diff: android_webview/lib/main/aw_main_delegate.cc

Issue 11471040: [Android WebView] Convert context menu callback to long press (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Avoid ownership weirdness by using aw_contents (like in PS1). FactoryFn. Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/lib/main/aw_main_delegate.cc
diff --git a/android_webview/lib/main/aw_main_delegate.cc b/android_webview/lib/main/aw_main_delegate.cc
index 7082797df069ab2dfe0882c9648740d7b7a5bac2..d4f91ee38c7e28c41820acbbdc0c9624b3284ee3 100644
--- a/android_webview/lib/main/aw_main_delegate.cc
+++ b/android_webview/lib/main/aw_main_delegate.cc
@@ -4,8 +4,8 @@
#include "android_webview/lib/main/aw_main_delegate.h"
-#include "android_webview/browser/aw_content_browser_client.h"
#include "android_webview/lib/aw_browser_dependency_factory_impl.h"
+#include "android_webview/native/aw_web_contents_view_delegate.h"
#include "android_webview/renderer/aw_content_renderer_client.h"
#include "base/lazy_instance.h"
#include "base/logging.h"
@@ -14,8 +14,6 @@
namespace android_webview {
-base::LazyInstance<AwContentBrowserClient>
- g_webview_content_browser_client = LAZY_INSTANCE_INITIALIZER;
base::LazyInstance<AwContentRendererClient>
g_webview_content_renderer_client = LAZY_INSTANCE_INITIALIZER;
@@ -66,7 +64,12 @@ void AwMainDelegate::ProcessExiting(const std::string& process_type) {
content::ContentBrowserClient*
AwMainDelegate::CreateContentBrowserClient() {
- return &g_webview_content_browser_client.Get();
+ if (!content_browser_client_) {
joth 2012/12/11 21:11:47 I *think* this check is not needed. (you can DCHEC
boliu 2012/12/11 22:13:10 does the ash shell support multiple web_contents?
+ content_browser_client_.reset(
+ new AwContentBrowserClient(&AwWebContentsViewDelegate::Create));
+ }
+
+ return content_browser_client_.get();
}
content::ContentRendererClient*

Powered by Google App Engine
This is Rietveld 408576698