[Android WebView] Convert context menu callback to long press

android_webview/browser/aw_content_browser_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "android_webview/browser/aw_content_browser_client.h"
 
 #include "android_webview/browser/aw_browser_main_parts.h"
 #include "android_webview/browser/aw_cookie_access_policy.h"
 #include "android_webview/browser/aw_quota_permission_context.h"
+#include "android_webview/browser/aw_web_contents_view_delegate_factory.h"
 #include "android_webview/browser/net_disk_cache_remover.h"
 #include "android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.h"
 #include "android_webview/common/url_constants.h"
 #include "base/base_paths_android.h"
 #include "base/path_service.h"
 #include "content/public/browser/access_token_store.h"
 #include "content/public/browser/child_process_security_policy.h"
 #include "content/public/browser/render_process_host.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/common/url_constants.h"
@@ skipping 35 matching lines @@
 
 AwBrowserContext* AwContentBrowserClient::GetAwBrowserContext() {
   return browser_context_.get();
 }
 
 content::BrowserMainParts* AwContentBrowserClient::CreateBrowserMainParts(
     const content::MainFunctionParams& parameters) {
   return new AwBrowserMainParts(browser_context_.get());
 }
 
+content::WebContentsViewDelegate*
+AwContentBrowserClient::GetWebContentsViewDelegate(
+    content::WebContents* web_contents) {
+  return CreateAwWebContentsViewDelegate(web_contents);

[joth, 2012/12/11 01:22:11]

this works ok.. but rather than call straight out to a static function here, it
would be better to have a factory {interface|callback} passed into the
AwContentBrowserClient constructor (as aw/lib can see all layers).
(AwContentBrowserClient could be a straight member of AwMainDelegate now, no
need for the lazy instance in there)

callback or interface: either have it as an abstract base class, or typedef for
a Callback<WebContentsViewDelegate*(WebContents*)>. either seems ok to me.  you
can just declare the abstract interface/callback in in
aw_content_browser_client.h, no need for the factory header.

There's a risk that such an injected factory will just grow to replicate most of
the AwContentBrowserClient interface at which point we'll conclude 
AwContentBrowserClient should just have been defined in the native layer
anyway...
keeping it as a focused WebContentsViewDelegateFactory would reduce chance of
that. 

[boliu, 2012/12/11 02:25:34]

Choosing callback since it's easier.

One snag in making AwContentBrowserClient an straight instance variable of
AwMainDelegate is that it causes the error:

F/chromium(20632): [1210/181208:FATAL:jni_android.cc(133)] Check failed:
!g_application_context.Get().is_null().

ie GetApplicationContext is called before InitApplicationContext. No useful
stack trace from master. Solution for now is to use scoped_ptr and create it
lazily...

+}
+
 void AwContentBrowserClient::RenderProcessHostCreated(
     content::RenderProcessHost* host) {
   // If WebView becomes multi-process capable, this may be insecure.
   // More benefit can be derived from the ChildProcessSecurotyPolicy by
   // deferring the GrantScheme calls until we know that a given child process
   // really does need that priviledge. Check here to ensure we rethink this
   // when the time comes. See crbug.com/156062.
   CHECK(content::RenderProcessHost::run_renderer_in_process());
 
   // Grant content: and file: scheme to the whole process, since we impose
@@ skipping 247 matching lines @@
 
 bool AwContentBrowserClient::AllowPepperSocketAPI(
     content::BrowserContext* browser_context,
     const GURL& url,
     const content::SocketPermissionRequest& params) {
   NOTREACHED() << "Android WebView does not support plugins";
   return false;
 }
 
 }  // namespace android_webview