Issue 11471028: Handlify JSObject::SetDictionaryElement, which may call back into JS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11471028: Handlify JSObject::SetDictionaryElement, which may call back into JS. (Closed)

Created:
8 years ago by rossberg

Modified:
8 years ago

Reviewers:
Michael Starzinger

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Handlify JSObject::SetDictionaryElement, which may call back into JS. Fixes flaky crasher in proxies.js test. R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=13169

Patch Set 2 : Addressed comment #

Created: 8 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -32 lines)			Patch
	M	src/objects.cc	View	1	6 chunks	+31 lines, -32 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Michael Starzinger

LGTM (with one comments). https://codereview.chromium.org/11471028/diff/1/src/objects.cc File src/objects.cc (right): https://codereview.chromium.org/11471028/diff/1/src/objects.cc#newcode10253 src/objects.cc:10253: if (IsJSArray()) { This needs ...

8 years ago (2012-12-07 12:39:32 UTC) #2

rossberg

8 years ago (2012-12-07 12:48:01 UTC) #3

https://codereview.chromium.org/11471028/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/11471028/diff/1/src/objects.cc#newcode10253
src/objects.cc:10253: if (IsJSArray()) {
On 2012/12/07 12:39:32, Michael Starzinger wrote:
> This needs to be self->IsJSArray() as well!

Done.

Expand Messages | Collapse Messages

Issue 11471028: Handlify JSObject::SetDictionaryElement, which may call back into JS. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Addressed comment #

Messages