Added more tests for IncognitoModeAvailability.

chrome/browser/ui/ash/launcher/launcher_context_menu_unittest.cc

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/ash/launcher/launcher_context_menu.h"
+
+#include "ash/launcher/launcher.h"
+#include "ash/launcher/launcher_model.h"
+#include "ash/launcher/launcher_types.h"
+#include "chrome/app/chrome_command_ids.h"
+#include "chrome/browser/prefs/incognito_mode_prefs.h"
+#include "chrome/browser/prefs/pref_service.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/ui/ash/launcher/chrome_launcher_controller.h"
+#include "chrome/browser/ui/ash/launcher/chrome_launcher_controller_per_browser.h"
+#include "chrome/test/base/chrome_render_view_host_test_harness.h"
+#include "chrome/test/base/testing_profile.h"
+#include "content/public/test/test_browser_thread.h"
+#include "testing/gtest/include/gtest/gtest.h"
+#include "ui/aura/root_window.h"
+
+class TestChromeLauncherControllerPerBrowser :
+  public ChromeLauncherControllerPerBrowser {

[sky, 2013/01/14 16:03:37]

indent two more

[rustema, 2013/01/15 07:37:40]

Done.

+ public:
+  TestChromeLauncherControllerPerBrowser(
+      Profile* profile, ash::LauncherModel* model)
+      : ChromeLauncherControllerPerBrowser(profile, model) {}
+  virtual bool IsLoggedInAsGuest() {

[sky, 2013/01/14 16:03:37]

OVERRIDE

[rustema, 2013/01/15 07:37:40]

Done.

+    return false;
+  }
+};

[sky, 2013/01/14 16:03:37]

private: DISALLOW...

[rustema, 2013/01/15 07:37:40]

Done.

+
+class LauncherContextMenuBrowserTest : public ChromeRenderViewHostTestHarness {

[sky, 2013/01/14 16:03:37]

BrowserTest -> Test

[rustema, 2013/01/15 07:37:40]

Done.

+ protected:
+  static bool IsItemPresentInMenu(LauncherContextMenu* menu, int command_id) {
+    DCHECK(menu);
+    return menu->GetIndexOfCommandId(command_id) != -1;
+  }
+
+  LauncherContextMenuBrowserTest()
+      : ChromeRenderViewHostTestHarness(),
+        browser_thread_(content::BrowserThread::UI, &message_loop_) {}
+
+  virtual void SetUp() {

[sky, 2013/01/14 16:03:37]

OVERRIDE where appropriate

[rustema, 2013/01/15 07:37:40]

Done.

+    ChromeRenderViewHostTestHarness::SetUp();
+    controller_.reset(
+        new TestChromeLauncherControllerPerBrowser(profile(),
+                                                   &launcher_model_));
+  }
+
+  virtual void TearDown() {
+    controller_.reset(NULL);
+    ChromeRenderViewHostTestHarness::TearDown();
+  }
+
+  LauncherContextMenu* CreateLauncherContextMenu(
+      ash::LauncherItemType launcher_item_type) {
+    ash::LauncherItem item;
+    item.id = 1;  // dummy id
+    item.type = launcher_item_type;
+    return new LauncherContextMenu(controller_.get(), &item, root_window());
+  }
+ private:

[sky, 2013/01/14 16:03:37]

newline between 62/63.

[rustema, 2013/01/15 07:37:40]

Done.

+  content::TestBrowserThread browser_thread_;
+  ash::LauncherModel launcher_model_;
+  scoped_ptr<ChromeLauncherController> controller_;
+};

[sky, 2013/01/14 16:03:37]

DISALLOW...

[rustema, 2013/01/15 07:37:40]

Done.

+
+// Verifies that "New Incognito window" menu item in the launcher context
+// menu is disabled when Incognito mode is switched off (by a policy).
+TEST_F(LauncherContextMenuBrowserTest,
+       NewIncognitoWindowMenuIsDisabledWhenIncognitoModeOff) {
+  // Initially, "New Incognito window" should be enabled.
+  scoped_ptr<LauncherContextMenu> menu(
+      CreateLauncherContextMenu(ash::TYPE_BROWSER_SHORTCUT));
+  ASSERT_TRUE(IsItemPresentInMenu(
+      menu.get(), LauncherContextMenu::MENU_NEW_INCOGNITO_WINDOW));
+  EXPECT_TRUE(menu->IsCommandIdEnabled(
+      LauncherContextMenu::MENU_NEW_INCOGNITO_WINDOW));
+
+  // Disable Incognito mode.
+  IncognitoModePrefs::SetAvailability(profile()->GetPrefs(),
+                                      IncognitoModePrefs::DISABLED);
+  menu.reset(CreateLauncherContextMenu(ash::TYPE_BROWSER_SHORTCUT));
+  // The item should be disabled.
+  ASSERT_TRUE(IsItemPresentInMenu(
+      menu.get(), LauncherContextMenu::MENU_NEW_INCOGNITO_WINDOW));
+  EXPECT_FALSE(menu->IsCommandIdEnabled(
+      LauncherContextMenu::MENU_NEW_INCOGNITO_WINDOW));
+}
+
+// Verifies that "New window" menu item in the launcher context
+// menu is disabled when Incognito mode is forced (by a policy).
+TEST_F(LauncherContextMenuBrowserTest,
+       NewWindowMenuIsDisabledWhenIncognitoModeForced) {
+  // Initially, "New window" should be enabled.
+  scoped_ptr<LauncherContextMenu> menu(
+      CreateLauncherContextMenu(ash::TYPE_BROWSER_SHORTCUT));
+  ASSERT_TRUE(IsItemPresentInMenu(
+      menu.get(), LauncherContextMenu::MENU_NEW_WINDOW));
+  EXPECT_TRUE(menu->IsCommandIdEnabled(LauncherContextMenu::MENU_NEW_WINDOW));
+
+  // Disable Incognito mode.
+  IncognitoModePrefs::SetAvailability(profile()->GetPrefs(),
+                                      IncognitoModePrefs::FORCED);
+  menu.reset(CreateLauncherContextMenu(ash::TYPE_BROWSER_SHORTCUT));
+  ASSERT_TRUE(IsItemPresentInMenu(
+      menu.get(), LauncherContextMenu::MENU_NEW_WINDOW));
+  EXPECT_FALSE(menu->IsCommandIdEnabled(LauncherContextMenu::MENU_NEW_WINDOW));
+}