Issue 11471011: Add PPAPI permissions for the testing interface

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11471011: Add PPAPI permissions for the testing interface (Closed)

Created:
8 years ago by brettw

Modified:
8 years ago

Reviewers:
bbudge

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add PPAPI permissions for the testing interface This is partially a reland of part of r167727 with some additions. Original review URL: https://codereview.chromium.org/11365235 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=172185

Patch Set 3 : #

Total comments: 2

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -3 lines)			Patch
M	chrome/browser/nacl_host/nacl_process_host.cc	View	1 2	2 chunks	+9 lines, -1 line	1 comment	Download
M	chrome/renderer/pepper/ppb_nacl_private_impl.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	ppapi/proxy/ppb_testing_proxy.cc	View		1 chunk	+3 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

bbudge

lgtm https://codereview.chromium.org/11471011/diff/11001/chrome/browser/nacl_host/nacl_process_host.cc File chrome/browser/nacl_host/nacl_process_host.cc (right): https://codereview.chromium.org/11471011/diff/11001/chrome/browser/nacl_host/nacl_process_host.cc#newcode118 chrome/browser/nacl_host/nacl_process_host.cc:118: ppapi::PpapiPermissions GetNaClPermissions(uint32 permission_bits) { Good idea to restrict ...

8 years ago (2012-12-07 22:23:41 UTC) #1

brettw

I'm treating the testing one specially. I don't think it's a dev interface, it should ...

8 years ago (2012-12-08 00:34:55 UTC) #2

bbudge

8 years ago (2012-12-08 00:44:39 UTC) #3

OK. I guess developers can still use it with a command line flag.
LGTM

Expand Messages | Collapse Messages

Issue 11471011: Add PPAPI permissions for the testing interface (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages