media/mp4/mp4_stream_parser_unittest.cc - Issue 11471006: Log MediaSource parsing errors to the MediaLog so they can appear in chrome:media-internals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/mp4/mp4_stream_parser_unittest.cc

Issue 11471006: Log MediaSource parsing errors to the MediaLog so they can appear in chrome:media-internals. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix nit. Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/mp4/mp4_stream_parser_unittest.cc

diff --git a/media/mp4/mp4_stream_parser_unittest.cc b/media/mp4/mp4_stream_parser_unittest.cc

index 81dbdd88a75dcc88b9a392d9261a72286db1dc4c..66f3410e97e386bfb6d6b2552588bb13bba849b6 100644

--- a/media/mp4/mp4_stream_parser_unittest.cc

+++ b/media/mp4/mp4_stream_parser_unittest.cc

@@ -106,7 +106,8 @@ class MP4StreamParserTest : public testing::Test {

base::Bind(&MP4StreamParserTest::KeyNeededF, base::Unretained(this)),

base::Bind(&MP4StreamParserTest::NewSegmentF, base::Unretained(this)),

base::Bind(&MP4StreamParserTest::EndOfSegmentF,

- base::Unretained(this)));

+ base::Unretained(this)),

+ LogCB());

}

bool ParseMP4File(const std::string& filename, int append_bytes) {

« no previous file with comments | « media/mp4/mp4_stream_parser.cc ('k') | media/mp4/track_run_iterator.h » ('j') | no next file with comments »