Log MediaSource parsing errors to the MediaLog so they can appear in chrome:media-internals.

media/mp4/box_reader.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/mp4/box_reader.h"
 
 #include <string.h>
 #include <algorithm>
 #include <map>
 #include <set>
@@ skipping 61 matching lines @@
 
 bool BufferReader::Read4sInto8s(int64* v) {
   // Beware of the need for sign extension.
   int32 tmp;
   RCHECK(Read4s(&tmp));
   *v = tmp;
   return true;
 }
 
 
-BoxReader::BoxReader(const uint8* buf, const int size)
+BoxReader::BoxReader(const uint8* buf, const int size,
+                     const LogCB& log_cb)
     : BufferReader(buf, size),
+      log_cb_(log_cb),
       type_(FOURCC_NULL),
       version_(0),
       flags_(0),
       scanned_(false) {
 }
 
 BoxReader::~BoxReader() {
   if (scanned_ && !children_.empty()) {
     for (ChildMap::iterator itr = children_.begin();
          itr != children_.end(); ++itr) {
       DVLOG(1) << "Skipping unknown box: " << FourCCToString(itr->first);
     }
   }
 }
 
 // static
 BoxReader* BoxReader::ReadTopLevelBox(const uint8* buf,
                                       const int buf_size,
+                                      const LogCB& log_cb,
                                       bool* err) {
-  scoped_ptr<BoxReader> reader(new BoxReader(buf, buf_size));
+  scoped_ptr<BoxReader> reader(new BoxReader(buf, buf_size, log_cb));
   if (!reader->ReadHeader(err))
     return NULL;
 
-  if (!IsValidTopLevelBox(reader->type())) {
+  if (!IsValidTopLevelBox(reader->type(), log_cb)) {
     *err = true;
     return NULL;
   }
 
   if (reader->size() <= buf_size)
     return reader.release();
 
   return NULL;
 }
 
 // static
 bool BoxReader::StartTopLevelBox(const uint8* buf,
                                  const int buf_size,
+                                 const LogCB& log_cb,
                                  FourCC* type,
                                  int* box_size,
                                  bool* err) {
-  BoxReader reader(buf, buf_size);
+  BoxReader reader(buf, buf_size, log_cb);
   if (!reader.ReadHeader(err)) return false;
-  if (!IsValidTopLevelBox(reader.type())) {
+  if (!IsValidTopLevelBox(reader.type(), log_cb)) {
     *err = true;
     return false;
   }
   *type = reader.type();
   *box_size = reader.size();
   return true;
 }
 
 // static
-bool BoxReader::IsValidTopLevelBox(const FourCC& type) {
+bool BoxReader::IsValidTopLevelBox(const FourCC& type,
+                                   const LogCB& log_cb) {
   switch (type) {
     case FOURCC_FTYP:
     case FOURCC_PDIN:
     case FOURCC_MOOV:
     case FOURCC_MOOF:
     case FOURCC_MFRA:
     case FOURCC_MDAT:
     case FOURCC_FREE:
     case FOURCC_SKIP:
     case FOURCC_META:
     case FOURCC_MECO:
     case FOURCC_STYP:
     case FOURCC_SIDX:
     case FOURCC_SSIX:
     case FOURCC_PRFT:
       return true;
     default:
       // Hex is used to show nonprintable characters and aid in debugging
-      LOG(WARNING) << "Unrecognized top-level box type 0x"
-                   << std::hex << type;
+      MEDIA_LOG(log_cb) << "Unrecognized top-level box type 0x"
+                        << std::hex << type;
       return false;
   }
 }
 
 bool BoxReader::ScanChildren() {
   DCHECK(!scanned_);
   scanned_ = true;
 
   bool err = false;
   while (pos() < size()) {
-    BoxReader child(&buf_[pos_], size_ - pos_);
+    BoxReader child(&buf_[pos_], size_ - pos_, log_cb_);
     if (!child.ReadHeader(&err)) break;
 
     children_.insert(std::pair<FourCC, BoxReader>(child.type(), child));
     pos_ += child.size();
   }
 
   DCHECK(!err);
   return !err && pos() == size();
 }
 
@@ skipping 47 matching lines @@
   }
 
   // Note that the pos_ head has advanced to the byte immediately after the
   // header, which is where we want it.
   size_ = size;
   return true;
 }
 
 }  // namespace mp4
 }  // namespace media