Devtools[ResourceScriptMapping]: Ignore uiSourceCodes originated by other target's network project

Devtools[ResourceScriptMapping]: Ignore uiSourceCodes originated by other target's network project

BUG=481677
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195912

[sergeyv, 2015-05-26 07:34:41]

sergeyv@chromium.org changed reviewers:
+ pfeldman@chromium.org

[sergeyv, 2015-05-26 07:34:41]

sergeyv@chromium.org changed reviewers:
+ pfeldman@chromium.org

[pfeldman, 2015-05-26 13:03:33]

lgtm

https://codereview.chromium.org/1147093007/diff/20001/Source/devtools/front_e...
File Source/devtools/front_end/bindings/NetworkProject.js (right):

https://codereview.chromium.org/1147093007/diff/20001/Source/devtools/front_e...
Source/devtools/front_end/bindings/NetworkProject.js:206: var projectId =
uiSourceCode.project().id();
extract WebInspector.NetworkProject.targetForProject(project);

https://codereview.chromium.org/1147093007/diff/20001/Source/devtools/front_e...
Source/devtools/front_end/bindings/NetworkProject.js:207: var targetId =
parseInt(projectId.substring(0, projectId.indexOf(":")), 10);
no need to substring.

https://codereview.chromium.org/1147093007/diff/20001/Source/devtools/front_e...
File Source/devtools/front_end/sdk/Target.js (right):

https://codereview.chromium.org/1147093007/diff/20001/Source/devtools/front_e...
Source/devtools/front_end/sdk/Target.js:576: for (var target of this._targets) {
Since it is likely to be called for every uiSourceCode (of 60K in my workspace),
lets iterate using index. Or better yet put it into a map.

[sergeyv, 2015-05-26 13:53:17]

https://codereview.chromium.org/1147093007/diff/20001/Source/devtools/front_e...
File Source/devtools/front_end/bindings/NetworkProject.js (right):

https://codereview.chromium.org/1147093007/diff/20001/Source/devtools/front_e...
Source/devtools/front_end/bindings/NetworkProject.js:206: var projectId =
uiSourceCode.project().id();
On 2015/05/26 13:03:33, pfeldman wrote:
> extract WebInspector.NetworkProject.targetForProject(project);

Done.

https://codereview.chromium.org/1147093007/diff/20001/Source/devtools/front_e...
Source/devtools/front_end/bindings/NetworkProject.js:207: var targetId =
parseInt(projectId.substring(0, projectId.indexOf(":")), 10);
On 2015/05/26 13:03:33, pfeldman wrote:
> no need to substring.

Done.

https://codereview.chromium.org/1147093007/diff/20001/Source/devtools/front_e...
File Source/devtools/front_end/sdk/Target.js (right):

https://codereview.chromium.org/1147093007/diff/20001/Source/devtools/front_e...
Source/devtools/front_end/sdk/Target.js:576: for (var target of this._targets) {
On 2015/05/26 13:03:33, pfeldman wrote:
> Since it is likely to be called for every uiSourceCode (of 60K in my
workspace),
> lets iterate using index. Or better yet put it into a map.

Done.

[sergeyv, 2015-05-26 13:53:22]

The CQ bit was checked by sergeyv@chromium.org

[sergeyv, 2015-05-26 13:53:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1147093007/#ps40001
(title: "Address comments")

[commit-bot: I haz the power, 2015-05-26 13:53:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1147093007/40001

[sergeyv, 2015-05-26 15:39:12]

The CQ bit was checked by sergeyv@chromium.org

[sergeyv, 2015-05-26 15:39:12]

The patchset sent to the CQ was uploaded after l-g-t-m from
pfeldman@chromium.org
Link to the patchset: https://codereview.chromium.org/1147093007/#ps60001
(title: "Rebase test results")

[commit-bot: I haz the power, 2015-05-26 15:39:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1147093007/60001

[commit-bot: I haz the power, 2015-05-26 16:43:14]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=195912