content/browser/renderer_host/input/motion_event_android_unittest.cc - Issue 1147083005: Separate motion event touch geometry orientation from stylus orientation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/input/motion_event_android_unittest.cc

Issue 1147083005: Separate motion event touch geometry orientation from stylus orientation. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Aura Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/input/motion_event_android.cc ('k') | content/browser/renderer_host/input/motion_event_web.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/input/motion_event_android_unittest.cc

diff --git a/content/browser/renderer_host/input/motion_event_android_unittest.cc b/content/browser/renderer_host/input/motion_event_android_unittest.cc

index 9a33b318ab504942f66becb451a430373b28b682..855bfd3fdc9b4aca26de8e41755c4e430aca6d04 100644

--- a/content/browser/renderer_host/input/motion_event_android_unittest.cc

+++ b/content/browser/renderer_host/input/motion_event_android_unittest.cc

@@ -75,8 +75,8 @@ TEST(MotionEventAndroidTest, Constructor) {

EXPECT_EQ(p1.touch_major_pixels * kPixToDip, event.GetTouchMajor(1));

EXPECT_EQ(p0.touch_minor_pixels * kPixToDip, event.GetTouchMinor(0));

EXPECT_EQ(p1.touch_minor_pixels * kPixToDip, event.GetTouchMinor(1));

- EXPECT_EQ(p0.orientation_rad, event.GetOrientation(0));

- EXPECT_EQ(p1.orientation_rad, event.GetOrientation(1));

+ EXPECT_EQ(p0.orientation_rad, event.GetTouchOrientation(0));

+ EXPECT_EQ(p1.orientation_rad, event.GetTouchOrientation(1));

EXPECT_EQ(p0.id, event.GetPointerId(0));

EXPECT_EQ(p1.id, event.GetPointerId(1));

EXPECT_EQ(MotionEvent::TOOL_TYPE_FINGER, event.GetToolType(0));

@@ -165,8 +165,8 @@ TEST(MotionEventAndroidTest, InvalidOrientationsSanitized) {

p0,

p1);

- EXPECT_EQ(0.f, event.GetOrientation(0));

- EXPECT_EQ(0.f, event.GetOrientation(1));

+ EXPECT_EQ(0.f, event.GetTouchOrientation(0));

+ EXPECT_EQ(0.f, event.GetTouchOrientation(1));

}

TEST(MotionEventAndroidTest, NonEmptyHistoryForNonMoveEventsSanitized) {