Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 1147083002: mandoline: Fork the files service from the mojo repository. (Closed)

Created:
5 years, 7 months ago by Elliot Glaysher
Modified:
5 years, 7 months ago
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mandoline: Fork the files service from the mojo repository. This forks the code from //services/files/ in the mojo repository at commit af91be731e321b06f5f88a25ff42199feb578691. BUG=490237 Committed: https://crrev.com/0aa9eec172c697fb3546282bc099af64288d8c82 Cr-Commit-Position: refs/heads/master@{#330803}

Patch Set 1 #

Patch Set 2 : Rebase to ToT and merge with jam@'s application patch #

Patch Set 3 : Maybe fix android. #

Patch Set 4 : I have no idea what I'm doing. #

Patch Set 5 : Again #

Patch Set 6 : I think the problem was in the mandoline build.gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2681 lines, -2 lines) Patch
A components/filesystem/BUILD.gn View 1 2 3 4 1 chunk +53 lines, -0 lines 0 comments Download
A + components/filesystem/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
A components/filesystem/directory_impl.h View 1 chunk +63 lines, -0 lines 0 comments Download
A components/filesystem/directory_impl.cc View 1 chunk +353 lines, -0 lines 0 comments Download
A components/filesystem/directory_impl_unittest.cc View 1 chunk +200 lines, -0 lines 0 comments Download
A components/filesystem/file_impl.h View 1 chunk +70 lines, -0 lines 0 comments Download
A components/filesystem/file_impl.cc View 1 chunk +335 lines, -0 lines 0 comments Download
A components/filesystem/file_impl_unittest.cc View 1 chunk +693 lines, -0 lines 0 comments Download
A components/filesystem/files_impl.h View 1 chunk +41 lines, -0 lines 0 comments Download
A components/filesystem/files_impl.cc View 1 chunk +96 lines, -0 lines 0 comments Download
A components/filesystem/files_test_base.h View 1 chunk +105 lines, -0 lines 0 comments Download
A components/filesystem/files_test_base.cc View 1 chunk +33 lines, -0 lines 0 comments Download
A components/filesystem/futimens.h View 1 chunk +26 lines, -0 lines 0 comments Download
A components/filesystem/futimens_android.cc View 1 chunk +13 lines, -0 lines 0 comments Download
A components/filesystem/main.cc View 1 1 chunk +44 lines, -0 lines 0 comments Download
A + components/filesystem/public/interfaces/BUILD.gn View 1 chunk +6 lines, -2 lines 0 comments Download
A components/filesystem/public/interfaces/directory.mojom View 1 chunk +63 lines, -0 lines 0 comments Download
A components/filesystem/public/interfaces/file.mojom View 1 chunk +91 lines, -0 lines 0 comments Download
A components/filesystem/public/interfaces/files.mojom View 1 chunk +14 lines, -0 lines 0 comments Download
A components/filesystem/public/interfaces/types.mojom View 1 chunk +101 lines, -0 lines 0 comments Download
A components/filesystem/shared_impl.h View 1 chunk +33 lines, -0 lines 0 comments Download
A components/filesystem/shared_impl.cc View 1 chunk +81 lines, -0 lines 0 comments Download
A components/filesystem/util.h View 1 chunk +55 lines, -0 lines 0 comments Download
A components/filesystem/util.cc View 1 chunk +103 lines, -0 lines 0 comments Download
M mandoline/BUILD.gn View 1 2 3 4 5 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Elliot Glaysher
This copies the code with the absolute minimal changes to make it compile in a ...
5 years, 7 months ago (2015-05-20 20:26:34 UTC) #2
Ben Goodger (Google)
lgtm
5 years, 7 months ago (2015-05-20 21:02:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147083002/100001
5 years, 7 months ago (2015-05-20 21:05:46 UTC) #5
commit-bot: I haz the power
Committed patchset #6 (id:100001)
5 years, 7 months ago (2015-05-20 21:23:36 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 21:24:27 UTC) #7
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/0aa9eec172c697fb3546282bc099af64288d8c82
Cr-Commit-Position: refs/heads/master@{#330803}

Powered by Google App Engine
This is Rietveld 408576698