Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1147053003: Modified sunflower (Closed)

Created:
5 years, 7 months ago by vsm
Modified:
5 years, 6 months ago
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Modified sunflower Need to rebase over this pending CL before it's ready for review / landing: https://codereview.chromium.org/1143953004/ R=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/85baf9243aa8bbd848dfc1b99101cff10b5140c5

Patch Set 1 #

Patch Set 2 : Rebase against 114395300 #

Patch Set 3 : Add new expectations #

Patch Set 4 : Rebased #

Total comments: 6

Patch Set 5 : Refactor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -87 lines) Patch
A test/codegen/expect/sunflower/circle.js View 1 2 1 chunk +17 lines, -0 lines 0 comments Download
A test/codegen/expect/sunflower/painter.js View 1 2 3 4 1 chunk +50 lines, -0 lines 0 comments Download
M test/codegen/expect/sunflower/sunflower.html View 1 1 chunk +2 lines, -0 lines 0 comments Download
M test/codegen/expect/sunflower/sunflower.js View 1 2 3 4 5 chunks +14 lines, -44 lines 0 comments Download
M test/codegen/expect/sunflower/sunflower.txt View 1 2 3 4 1 chunk +1 line, -7 lines 0 comments Download
A + test/codegen/sunflower/circle.dart View 1 2 3 4 1 chunk +4 lines, -6 lines 0 comments Download
A test/codegen/sunflower/painter.dart View 1 2 3 4 1 chunk +38 lines, -0 lines 0 comments Download
M test/codegen/sunflower/sunflower.dart View 1 2 3 4 3 chunks +9 lines, -30 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
vsm
5 years, 7 months ago (2015-05-26 19:27:14 UTC) #2
vsm
On 2015/05/26 19:27:14, vsm wrote: Rebased against pending fixes to sunflower.
5 years, 6 months ago (2015-05-28 15:52:32 UTC) #3
Jennifer Messerly
suggested a few tweaks but LGTM regardless :) https://codereview.chromium.org/1147053003/diff/60001/test/codegen/sunflower/circle.dart File test/codegen/sunflower/circle.dart (right): https://codereview.chromium.org/1147053003/diff/60001/test/codegen/sunflower/circle.dart#newcode1 test/codegen/sunflower/circle.dart:1: // ...
5 years, 6 months ago (2015-05-28 21:04:22 UTC) #4
vsm
https://codereview.chromium.org/1147053003/diff/60001/test/codegen/sunflower/circle.dart File test/codegen/sunflower/circle.dart (right): https://codereview.chromium.org/1147053003/diff/60001/test/codegen/sunflower/circle.dart#newcode1 test/codegen/sunflower/circle.dart:1: // Copyright (c) 2012, the Dart project authors. Please ...
5 years, 6 months ago (2015-05-29 13:23:02 UTC) #5
vsm
5 years, 6 months ago (2015-05-29 13:25:02 UTC) #6
Message was sent while issue was closed.
Committed patchset #5 (id:80001) manually as
85baf9243aa8bbd848dfc1b99101cff10b5140c5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698