Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1147053002: Make SkEmptyPicture a singleton. (Closed)

Created:
5 years, 7 months ago by mtklein_C
Modified:
5 years, 7 months ago
Reviewers:
f(malita), mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make SkEmptyPicture a singleton. In my confusion yesterday I accidentally left this as a non-singleton. The issue in Blink was not related to this being a singleton, and it should be safe to make it one. This means recording an empty picture properly costs zero mallocs. BUG=skia: Committed: https://skia.googlesource.com/skia/+/2e172ecd3b0ed570f6bf27594c524ea63a606066

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -4 lines) Patch
M src/core/SkMiniRecorder.cpp View 1 4 chunks +3 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147053002/1
5 years, 7 months ago (2015-05-20 16:46:06 UTC) #2
mtklein_C
5 years, 7 months ago (2015-05-20 16:46:36 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-20 16:51:49 UTC) #6
f(malita)
lgtm
5 years, 7 months ago (2015-05-20 17:15:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1147053002/20001
5 years, 7 months ago (2015-05-20 17:26:14 UTC) #10
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 17:32:26 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/2e172ecd3b0ed570f6bf27594c524ea63a606066

Powered by Google App Engine
This is Rietveld 408576698